Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 215973006: Minor cleanup of FaviconHandler (Closed)

Created:
6 years, 8 months ago by sky
Modified:
6 years, 8 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Minor cleanup of FaviconHandler Nothing substantial here, just some name changes and other random cleanup. BUG=none TEST=none R=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261508

Patch Set 1 #

Patch Set 2 : rename in test too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -84 lines) Patch
M chrome/browser/favicon/favicon_handler.h View 7 chunks +24 lines, -18 lines 0 comments Download
M chrome/browser/favicon/favicon_handler.cc View 22 chunks +49 lines, -64 lines 0 comments Download
M chrome/browser/favicon/favicon_handler_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sky
6 years, 8 months ago (2014-04-02 22:19:40 UTC) #1
pkotwicz
LGTM
6 years, 8 months ago (2014-04-03 02:35:39 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-03 14:57:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/215973006/1
6 years, 8 months ago (2014-04-03 14:58:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 15:58:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-03 15:58:17 UTC) #6
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-03 16:21:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/215973006/20001
6 years, 8 months ago (2014-04-03 16:21:09 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 19:47:43 UTC) #9
Message was sent while issue was closed. 
Change committed as 261508

Powered by Google App Engine
This is Rietveld 408576698