chrome/browser/favicon/favicon_handler_unittest.cc - Issue 215973006: Minor cleanup of FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler_unittest.cc

Issue 215973006: Minor cleanup of FaviconHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rename in test too Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_handler_unittest.cc

diff --git a/chrome/browser/favicon/favicon_handler_unittest.cc b/chrome/browser/favicon/favicon_handler_unittest.cc

index d7bdb6a2e15087f5709641b08616b673051768b9..1e3456b0cf4ce81bb40a32aa0f03faf71706e92d 100644

--- a/chrome/browser/favicon/favicon_handler_unittest.cc

+++ b/chrome/browser/favicon/favicon_handler_unittest.cc

@@ -263,7 +263,7 @@ class TestFaviconHandler : public FaviconHandler {

icon_type, callback));

}

- virtual void GetFavicon(

+ virtual void GetFaviconFromFaviconService(

const GURL& icon_url,

chrome::IconType icon_type,

const FaviconService::FaviconResultsCallback& callback,

@@ -272,7 +272,7 @@ class TestFaviconHandler : public FaviconHandler {

icon_type, callback));

}

- virtual void GetFaviconForURL(

+ virtual void GetFaviconForURLFromFaviconService(

const GURL& page_url,

int icon_types,

const FaviconService::FaviconResultsCallback& callback,

« no previous file with comments | « chrome/browser/favicon/favicon_handler.cc ('k') | no next file » | no next file with comments »