third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h - Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: works Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template ('K') | « third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h ('k') | third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

index beee1155f6e87f547e404d5617684b0563feb991..141dfc734a095ff3ff5a5c19f5029aa7727d9dd7 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

@@ -7,7 +7,7 @@

#include "platform/inspector_protocol/Platform.h"

#include "platform/inspector_protocol/String16.h"

-#include "platform/v8_inspector/protocol/Runtime.h"

+#include "platform/v8_inspector/public/protocol/Runtime.h"

#include <v8.h>

@@ -24,7 +24,7 @@ public:

virtual String16 topFunctionName() const = 0;

virtual ~V8StackTrace() { }

- virtual std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObject() const = 0;

+ virtual std::unique_ptr<protocol::Runtime::Exported::StackTrace> buildInspectorObject() const = 0;

virtual String16 toString() const = 0;

virtual std::unique_ptr<V8StackTrace> clone() = 0;

virtual std::unique_ptr<V8StackTrace> isolatedCopy() = 0; // Safe to pass between threads.