third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h - Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: works Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template ('K') | « third_party/WebKit/Source/platform/v8_inspector/public/V8ContentSearchUtil.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

index 2103467e44087b4068d9038782bd39b21dae061a..ff825a157feb0422a63b61eb8124bcccb8a773f5 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

@@ -6,7 +6,7 @@

#define V8InspectorSession_h

#include "platform/inspector_protocol/Platform.h"

-#include "platform/v8_inspector/protocol/Runtime.h"

+#include "platform/v8_inspector/public/protocol/Runtime.h"

#include <v8.h>

@@ -40,7 +40,7 @@ public:

// Remote objects.

static const char backtraceObjectGroup[];

- virtual std::unique_ptr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName, bool generatePreview) = 0;

+ virtual std::unique_ptr<protocol::Runtime::Exported::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName) = 0;

virtual v8::Local<v8::Value> findObject(ErrorString*, const String16& objectId, v8::Local<v8::Context>* = nullptr, String16* objectGroup = nullptr) = 0;

virtual void releaseObjectGroup(const String16&) = 0;

};