Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tools/perf/benchmarks/v8_browsing.py

Issue 2159493002: [perfbot health] Disable v8.browsing_desktop.ref on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8_browsing.py
diff --git a/tools/perf/benchmarks/v8_browsing.py b/tools/perf/benchmarks/v8_browsing.py
index c7e4d87cae9921315dc29d7d691348a2b5c2e48d..f77db99b2986f9a0eb951783ca9cf8fdeec1a2d1 100644
--- a/tools/perf/benchmarks/v8_browsing.py
+++ b/tools/perf/benchmarks/v8_browsing.py
@@ -86,8 +86,12 @@ class V8DesktopBrowsingBenchmark(_V8BrowsingBenchmark):
@classmethod
def ShouldDisable(cls, possible_browser):
- return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
+ # http://crbug.com/628736
+ if (possible_browser.platform.GetOSName() == 'mac' and
+ possible_browser.browser_type == 'reference'):
+ return True
+ return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
@benchmark.Disabled('reference') # http://crbug.com/628631
class V8MobileBrowsingBenchmark(_V8BrowsingBenchmark):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698