Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: tools/perf/benchmarks/v8_browsing.py

Issue 2159493002: [perfbot health] Disable v8.browsing_desktop.ref on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry.timeline import chrome_trace_config 9 from telemetry.timeline import chrome_trace_config
10 from telemetry.timeline import chrome_trace_category_filter 10 from telemetry.timeline import chrome_trace_category_filter
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 @classmethod 79 @classmethod
80 def ShouldTearDownStateAfterEachStoryRun(cls): 80 def ShouldTearDownStateAfterEachStoryRun(cls):
81 return True 81 return True
82 82
83 83
84 class V8DesktopBrowsingBenchmark(_V8BrowsingBenchmark): 84 class V8DesktopBrowsingBenchmark(_V8BrowsingBenchmark):
85 PLATFORM = 'desktop' 85 PLATFORM = 'desktop'
86 86
87 @classmethod 87 @classmethod
88 def ShouldDisable(cls, possible_browser): 88 def ShouldDisable(cls, possible_browser):
89 # http://crbug.com/628736
90 if (possible_browser.platform.GetOSName() == 'mac' and
91 possible_browser.browser_type == 'reference'):
92 return True
93
89 return possible_browser.platform.GetDeviceTypeName() != 'Desktop' 94 return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
90 95
91
92 @benchmark.Disabled('reference') # http://crbug.com/628631 96 @benchmark.Disabled('reference') # http://crbug.com/628631
93 class V8MobileBrowsingBenchmark(_V8BrowsingBenchmark): 97 class V8MobileBrowsingBenchmark(_V8BrowsingBenchmark):
94 PLATFORM = 'mobile' 98 PLATFORM = 'mobile'
95 99
96 @classmethod 100 @classmethod
97 def ShouldDisable(cls, possible_browser): 101 def ShouldDisable(cls, possible_browser):
98 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' 102 return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698