third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h ('k') | third_party/WebKit/Source/modules/webaudio/AudioListener.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp

index b54d9b00f1ebc5c598b4e0f0718c004c1d99bf39..cb67fb9cb681838cf110dd16eb4fca12a0625962 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp

@@ -41,7 +41,7 @@ AudioDestinationHandler::AudioDestinationHandler(AudioNode& node, float sampleRa

AudioDestinationHandler::~AudioDestinationHandler()

{

- ASSERT(!isInitialized());

+ DCHECK(!isInitialized());

}

void AudioDestinationHandler::render(AudioBus* sourceBus, AudioBus* destinationBus, size_t numberOfFrames)

@@ -57,7 +57,7 @@ void AudioDestinationHandler::render(AudioBus* sourceBus, AudioBus* destinationB

// TODO(hongchan): because the context can go away while rendering, so this

// check cannot guarantee the safe execution of the following steps.

- ASSERT(context());

+ DCHECK(context());

if (!context())

return;

@@ -78,7 +78,7 @@ void AudioDestinationHandler::render(AudioBus* sourceBus, AudioBus* destinationB

if (sourceBus)

m_localAudioInputProvider.set(sourceBus);

- ASSERT(numberOfInputs() >= 1);

+ DCHECK_GE(static_cast<int>(numberOfInputs()), 1);

if (numberOfInputs() < 1) {

destinationBus->zero();

return;