third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h b/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h

index 2ecd418b04ea060e2ad328b709e6d4522ded12b7..a2c419a469b5e4eb25eeb45044ca653c52585bbc 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h

@@ -76,7 +76,7 @@ protected:

void provideInput(AudioBus* destinationBus, size_t numberOfFrames) override

{

bool isGood = destinationBus && destinationBus->length() == numberOfFrames && m_sourceBus->length() == numberOfFrames;

- ASSERT(isGood);

+ DCHECK(isGood);

if (isGood)

destinationBus->copyFrom(*m_sourceBus);

}