Cursor should respect text align in contenteditable with pseudo element

Cursor should respect text align in contenteditable with pseudo element.

Avoid considering PseudoElement's content as first child so that caret rect for empty element is calculated.

BUG=426586
Committed: https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3
Cr-Commit-Position: refs/heads/master@{#407421}

[ramya.v, 2016-07-20 08:12:12]

Description was changed from

==========
[WIP]

BUG=426586
==========

to

==========
Cursor should respect text align in contenteditable with pseudo element.

Avoid considering PseudoElement's content as first child so that caret rect for
empty element is calculated.

BUG=426586
==========

[ramya.v, 2016-07-20 08:30:25]

ramya.v@samsung.com changed reviewers:
+ yosin@chromium.org

[ramya.v, 2016-07-20 08:30:26]

PTAL!

Thanks

[yosin_UTC9, 2016-07-20 09:21:47]

yosin@chromium.org changed reviewers:
+ eae@chromium.org

[yosin_UTC9, 2016-07-20 09:21:48]

non-owner lgtm w/ nits in tests

+eae@ for LayoutBlock.cpp changes

https://codereview.chromium.org/2159373003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/selection/caret-in-empty-div-with-pseudo-content.html
(right):

https://codereview.chromium.org/2159373003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/caret-in-empty-div-with-pseudo-content.html:23:
caretRect1 = internals.absoluteCaretBounds(document);
nit: Please add |var|.

https://codereview.chromium.org/2159373003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/caret-in-empty-div-with-pseudo-content.html:27:
caretRect2 = internals.absoluteCaretBounds(document);
nit: Please add |var|.

https://codereview.chromium.org/2159373003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/caret-in-empty-div-with-pseudo-content.html:29:
assert_false(caretRect1.left == caretRect2.left);
nit: Please use assert_equals()

[ramya.v, 2016-07-20 09:36:46]

Updated as per review comments.

https://codereview.chromium.org/2159373003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/selection/caret-in-empty-div-with-pseudo-content.html
(right):

https://codereview.chromium.org/2159373003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/caret-in-empty-div-with-pseudo-content.html:23:
caretRect1 = internals.absoluteCaretBounds(document);
On 2016/07/20 09:21:48, Yosi_UTC9 wrote:
> nit: Please add |var|.

Done.

https://codereview.chromium.org/2159373003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/caret-in-empty-div-with-pseudo-content.html:27:
caretRect2 = internals.absoluteCaretBounds(document);
On 2016/07/20 09:21:48, Yosi_UTC9 wrote:
> nit: Please add |var|.

Done.

https://codereview.chromium.org/2159373003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/caret-in-empty-div-with-pseudo-content.html:29:
assert_false(caretRect1.left == caretRect2.left);
On 2016/07/20 09:21:48, Yosi_UTC9 wrote:
> nit: Please use assert_equals()

Done.

[eae, 2016-07-20 16:29:27]

LGTM for layout

[ramya.v, 2016-07-21 03:19:30]

The CQ bit was checked by ramya.v@samsung.com

[ramya.v, 2016-07-21 03:19:31]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2159373003/#ps40001
(title: "Updated as per review comments")

[commit-bot: I haz the power, 2016-07-21 03:19:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 04:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 04:02:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ramya.v, 2016-07-21 06:26:02]

@eae Updated ASSERT statement.
Could you please take a look.


Thanks

[ramya.v, 2016-07-25 05:20:00]

The CQ bit was checked by ramya.v@samsung.com

[ramya.v, 2016-07-25 05:20:00]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2159373003/#ps60001
(title: "Updated ASSERT")

[commit-bot: I haz the power, 2016-07-25 05:20:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 07:15:57]

Description was changed from

==========
Cursor should respect text align in contenteditable with pseudo element.

Avoid considering PseudoElement's content as first child so that caret rect for
empty element is calculated.

BUG=426586
==========

to

==========
Cursor should respect text align in contenteditable with pseudo element.

Avoid considering PseudoElement's content as first child so that caret rect for
empty element is calculated.

BUG=426586
==========

[commit-bot: I haz the power, 2016-07-25 07:15:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-25 07:17:17]

Description was changed from

==========
Cursor should respect text align in contenteditable with pseudo element.

Avoid considering PseudoElement's content as first child so that caret rect for
empty element is calculated.

BUG=426586
==========

to

==========
Cursor should respect text align in contenteditable with pseudo element.

Avoid considering PseudoElement's content as first child so that caret rect for
empty element is calculated.

BUG=426586

Committed: https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3
Cr-Commit-Position: refs/heads/master@{#407421}
==========

[commit-bot: I haz the power, 2016-07-25 07:17:18]

Patchset 4 (id:??) landed as
https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3
Cr-Commit-Position: refs/heads/master@{#407421}