third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2159373003: Cursor should respect text align in contenteditable with pseudo element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2159373003: Cursor should respect text align in contenteditable with pseudo element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated ASSERT Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index 5390b7360ae1ca2e7fe1d29e0e78682f75fafc1b..2770ee119b98d3819a94c52cf90ee5ac288b2bf7 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -943,7 +943,7 @@ void LayoutBoxModelObject::computeLayerHitTestRects(LayerHitTestRects& rects) co

LayoutRect LayoutBoxModelObject::localCaretRectForEmptyElement(LayoutUnit width, LayoutUnit textIndentOffset)

{

- ASSERT(!slowFirstChild());

+ DCHECK(!slowFirstChild() || slowFirstChild()->isPseudoElement());

// FIXME: This does not take into account either :first-line or :first-letter

// However, as soon as some content is entered, the line boxes will be

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | no next file » | no next file with comments »