net: make CanonicalCookie's constructor private

ios/net/cookies/system_cookie_util.mm

Index: ios/net/cookies/system_cookie_util.mm
diff --git a/ios/net/cookies/system_cookie_util.mm b/ios/net/cookies/system_cookie_util.mm
index 9c371dca41782df8e9a2c98f6f8c79cdd1e6671a..0a9c67a4d13972bf4b6fc71636967029e111eb0c 100644
--- a/ios/net/cookies/system_cookie_util.mm
+++ b/ios/net/cookies/system_cookie_util.mm
@@ -66,16 +66,16 @@ void ReportUMACookieLoss(CookieLossType loss, CookieEvent event) {
 net::CanonicalCookie CanonicalCookieFromSystemCookie(
     NSHTTPCookie* cookie,
     const base::Time& ceation_time) {
-  return net::CanonicalCookie(
-      GURL(), base::SysNSStringToUTF8([cookie name]),
+  return *net::CanonicalCookie::Create(
+      GURL("http://example.com"), base::SysNSStringToUTF8([cookie name]),

[mmenke, 2016/07/20 20:50:11]

I think this one is the issue.  Switch it to using the constructor that doesn't
take a GURL, and I think iOS will magically work.  (i.e, just delete the first
argument)

[tfarina, 2016/07/20 21:58:47]

Done.

       base::SysNSStringToUTF8([cookie value]),
       base::SysNSStringToUTF8([cookie domain]),
       base::SysNSStringToUTF8([cookie path]), ceation_time,
       base::Time::FromDoubleT([[cookie expiresDate] timeIntervalSince1970]),
-      base::Time(), [cookie isSecure], [cookie isHTTPOnly],
+      [cookie isSecure], [cookie isHTTPOnly],
       // TODO(mkwst): When iOS begins to support 'SameSite' and 'Priority'
       // attributes, pass them through here.
-      net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT);
+      net::CookieSameSite::DEFAULT_MODE, false, net::COOKIE_PRIORITY_DEFAULT);
 }
 
 // Converts net::CanonicalCookie to NSHTTPCookie.