net: make CanonicalCookie's constructor private

ios/net/cookies/system_cookie_util.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/net/cookies/system_cookie_util.h"
 
 #import <Foundation/Foundation.h>
 #include <stddef.h>
 
 #include "base/logging.h"
@@ skipping 48 matching lines @@
       break;
   }
 }
 
 }  // namespace
 
 // Converts NSHTTPCookie to net::CanonicalCookie.
 net::CanonicalCookie CanonicalCookieFromSystemCookie(
     NSHTTPCookie* cookie,
     const base::Time& ceation_time) {
-  return net::CanonicalCookie(
-      GURL(), base::SysNSStringToUTF8([cookie name]),
+  return *net::CanonicalCookie::Create(
+      GURL("http://example.com"), base::SysNSStringToUTF8([cookie name]),

[mmenke, 2016/07/20 20:50:11]

I think this one is the issue.  Switch it to using the constructor that doesn't
take a GURL, and I think iOS will magically work.  (i.e, just delete the first
argument)

[tfarina, 2016/07/20 21:58:47]

Done.

       base::SysNSStringToUTF8([cookie value]),
       base::SysNSStringToUTF8([cookie domain]),
       base::SysNSStringToUTF8([cookie path]), ceation_time,
       base::Time::FromDoubleT([[cookie expiresDate] timeIntervalSince1970]),
-      base::Time(), [cookie isSecure], [cookie isHTTPOnly],
+      [cookie isSecure], [cookie isHTTPOnly],
       // TODO(mkwst): When iOS begins to support 'SameSite' and 'Priority'
       // attributes, pass them through here.
-      net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT);
+      net::CookieSameSite::DEFAULT_MODE, false, net::COOKIE_PRIORITY_DEFAULT);
 }
 
 // Converts net::CanonicalCookie to NSHTTPCookie.
 NSHTTPCookie* SystemCookieFromCanonicalCookie(
     const net::CanonicalCookie& cookie) {
   NSString* cookie_domain = base::SysUTF8ToNSString(cookie.Domain());
   NSString* cookie_name = base::SysUTF8ToNSString(cookie.Name());
   NSString* cookie_path = base::SysUTF8ToNSString(cookie.Path());
   NSString* cookie_value = base::SysUTF8ToNSString(cookie.Value());
   if (!cookie_domain || !cookie_name || !cookie_path || !cookie_value) {
@@ skipping 58 matching lines @@
   ResetCookieCountMetrics();
 }
 
 void ResetCookieCountMetrics() {
   NSUserDefaults* defaults = [NSUserDefaults standardUserDefaults];
   [defaults setBool:NO forKey:kCheckCookieLossKey];
   [defaults synchronize];
 }
 
 }  // namespace net