Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: net/cookies/canonical_cookie.cc

Issue 2159373002: net: make CanonicalCookie's constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix CookieStore test? Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cookies/canonical_cookie.cc
diff --git a/net/cookies/canonical_cookie.cc b/net/cookies/canonical_cookie.cc
index d117d5ee3482e60fcccac79431600e1b6f9b83f7..9bc43a3fc0b5a05e2c6ab02ba78821e65373559f 100644
--- a/net/cookies/canonical_cookie.cc
+++ b/net/cookies/canonical_cookie.cc
@@ -125,6 +125,10 @@ CanonicalCookie::CanonicalCookie()
httponly_(false) {
}
+CanonicalCookie::CanonicalCookie(const CanonicalCookie& other) = default;
+
+CanonicalCookie::~CanonicalCookie() {}
+
CanonicalCookie::CanonicalCookie(const GURL& url,
mmenke 2016/07/21 15:34:57 nit: This should be moved down below FullCompare,
tfarina 2016/07/21 19:05:41 Done.
tfarina 2016/07/21 19:05:41 Looks like CanonPath is not at the right place eit
const std::string& name,
const std::string& value,
@@ -149,11 +153,6 @@ CanonicalCookie::CanonicalCookie(const GURL& url,
same_site_(same_site),
priority_(priority) {}
-CanonicalCookie::CanonicalCookie(const CanonicalCookie& other) = default;
-
-CanonicalCookie::~CanonicalCookie() {
-}
-
// static
std::string CanonicalCookie::CanonPath(const GURL& url,
const ParsedCookie& pc) {

Powered by Google App Engine
This is Rietveld 408576698