net: make CanonicalCookie's constructor private

net/cookies/canonical_cookie.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Portions of this code based on Mozilla:
 //   (netwerk/cookie/src/nsCookieService.cpp)
 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
@@ skipping 107 matching lines @@
   return a.Path().compare(b.Path());
 }
 
 }  // namespace
 
 CanonicalCookie::CanonicalCookie()
     : secure_(false),
       httponly_(false) {
 }
 
+CanonicalCookie::CanonicalCookie(const CanonicalCookie& other) = default;
+
+CanonicalCookie::~CanonicalCookie() {}
+
 CanonicalCookie::CanonicalCookie(const GURL& url,

[mmenke, 2016/07/21 15:34:57]

nit:  This should be moved down below FullCompare, to match declaration order.

[tfarina, 2016/07/21 19:05:41]

Done.

[tfarina, 2016/07/21 19:05:41]

Looks like CanonPath is not at the right place either, but I'm not going to move
it, just the code I'm touching.

                                  const std::string& name,
                                  const std::string& value,
                                  const std::string& domain,
                                  const std::string& path,
                                  const base::Time& creation,
                                  const base::Time& expiration,
                                  const base::Time& last_access,
                                  bool secure,
                                  bool httponly,
                                  CookieSameSite same_site,
                                  CookiePriority priority)
     : name_(name),
       value_(value),
       domain_(domain),
       path_(path),
       creation_date_(creation),
       expiry_date_(expiration),
       last_access_date_(last_access),
       secure_(secure),
       httponly_(httponly),
       same_site_(same_site),
       priority_(priority) {}
 
-CanonicalCookie::CanonicalCookie(const CanonicalCookie& other) = default;
-
-CanonicalCookie::~CanonicalCookie() {
-}
-
 // static
 std::string CanonicalCookie::CanonPath(const GURL& url,
                                        const ParsedCookie& pc) {
   std::string path_string;
   if (pc.HasPath())
     path_string = pc.Path();
   return CanonPathWithString(url, path_string);
 }
 
 // static
@@ skipping 356 matching lines @@
   return true;
 }
 
 std::string CanonicalCookie::DomainWithoutDot() const {
   if (domain_.empty() || domain_[0] != '.')
     return domain_;
   return domain_.substr(1);
 }
 
 }  // namespace net