Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: ios/net/cookies/cookie_store_ios_unittest.mm

Issue 2159373002: net: make CanonicalCookie's constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix CookieStore test? Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/net/cookies/cookie_store_ios_unittest.mm
diff --git a/ios/net/cookies/cookie_store_ios_unittest.mm b/ios/net/cookies/cookie_store_ios_unittest.mm
index d709910ed6794047ddf55de63fcc2986923feb47..6971d43c7ea3add005b0690debe7a76094171b39 100644
--- a/ios/net/cookies/cookie_store_ios_unittest.mm
+++ b/ios/net/cookies/cookie_store_ios_unittest.mm
@@ -259,16 +259,16 @@ class TestPersistentCookieStore
// Some canonical cookies cannot be converted into System cookies, for
// example if value is not valid utf8. Such cookies are ignored.
- net::CanonicalCookie* bad_canonical_cookie = new net::CanonicalCookie(
- kTestCookieURL, "name", "\x81r\xe4\xbd\xa0\xe5\xa5\xbd", "domain",
- "path/",
- base::Time(), // creation
- base::Time(), // expires
- base::Time(), // last_access
- false, // secure
- false, // httponly
- net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT);
- cookies.push_back(bad_canonical_cookie);
+ std::unique_ptr<net::CanonicalCookie> bad_canonical_cookie(
+ net::CanonicalCookie::Create(
mmenke 2016/07/21 15:34:57 To keep old behavior, add "GURL("http://domain/")"
tfarina 2016/07/21 19:05:41 Done.
+ "name", "\x81r\xe4\xbd\xa0\xe5\xa5\xbd", std::string(), "path/",
+ base::Time(), // creation
+ base::Time(), // expires
+ base::Time(), // last_access
+ false, // secure
+ false, // httponly
+ net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
+ cookies.push_back(bad_canonical_cookie.release());
loaded_callback_.Run(cookies);
}

Powered by Google App Engine
This is Rietveld 408576698