ios/net/cookies/system_cookie_util.mm - Issue 2159373002: net: make CanonicalCookie's constructor private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/net/cookies/system_cookie_util.mm

Issue 2159373002: net: make CanonicalCookie's constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix CookieStore test? Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/net/cookies/system_cookie_util.mm

diff --git a/ios/net/cookies/system_cookie_util.mm b/ios/net/cookies/system_cookie_util.mm

index 9c371dca41782df8e9a2c98f6f8c79cdd1e6671a..b0c13881f2f037ef3dea87e2f818bc8dddf3acf2 100644

--- a/ios/net/cookies/system_cookie_util.mm

+++ b/ios/net/cookies/system_cookie_util.mm

@@ -66,8 +66,8 @@ void ReportUMACookieLoss(CookieLossType loss, CookieEvent event) {

net::CanonicalCookie CanonicalCookieFromSystemCookie(

NSHTTPCookie* cookie,

const base::Time& ceation_time) {

- return net::CanonicalCookie(

- GURL(), base::SysNSStringToUTF8([cookie name]),

+ return *net::CanonicalCookie::Create(

+ base::SysNSStringToUTF8([cookie name]),

base::SysNSStringToUTF8([cookie value]),

base::SysNSStringToUTF8([cookie domain]),

base::SysNSStringToUTF8([cookie path]), ceation_time,