Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2159333002: Recycle small uniform buffers. (Closed)

Created:
4 years, 5 months ago by jvanverth1
Modified:
4 years, 5 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -24 lines) Patch
M src/gpu/vk/GrVkBuffer.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkBuffer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkResourceProvider.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkResourceProvider.cpp View 1 4 chunks +30 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkUniformBuffer.h View 1 2 chunks +20 lines, -9 lines 0 comments Download
M src/gpu/vk/GrVkUniformBuffer.cpp View 1 1 chunk +69 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jvanverth1
4 years, 5 months ago (2016-07-19 19:07:25 UTC) #3
egdaniel
In general looks fine. Just the questions we've talked about involving multiple objects holding refs ...
4 years, 5 months ago (2016-07-19 20:48:38 UTC) #4
jvanverth1
Updated to use new recycling system. PTAL.
4 years, 5 months ago (2016-07-22 16:29:13 UTC) #5
egdaniel
lgtm
4 years, 5 months ago (2016-07-22 17:08:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159333002/20001
4 years, 5 months ago (2016-07-22 17:08:50 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:34:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4c6e47a8a827077e36fa5feb4ab5ac7435d8276b

Powered by Google App Engine
This is Rietveld 408576698