Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2159293002: Plumb explicit IPC task runner through to IPC::Channel creation (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb explicit IPC task runner through to IPC::Channel creation In preparation for a follow-up CL, IPC::ChannelMojo needs to know which TaskRunner it will be used from despite being constructed on some arbitray other thread (for e.g. ChannelProxy). This CL plumbs through an IPC TaskRunner to various Channel instantiation sites to avoid lots of noise in the other CL. There are no behavioral changes introduced here. BUG=612500, 619202 Committed: https://crrev.com/a34707ca8e2548fcc804ffaa9571adcba2d024a8 Cr-Commit-Position: refs/heads/master@{#406486}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : add dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -76 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ipc/ipc_channel.h View 4 chunks +7 lines, -4 lines 0 comments Download
M ipc/ipc_channel_common.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M ipc/ipc_channel_factory.h View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M ipc/ipc_channel_factory.cc View 1 2 3 chunks +16 lines, -5 lines 0 comments Download
M ipc/ipc_channel_mojo.h View 3 chunks +16 lines, -6 lines 0 comments Download
M ipc/ipc_channel_mojo.cc View 1 2 2 chunks +31 lines, -14 lines 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 6 chunks +25 lines, -11 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ipc/ipc_mojo_perftest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_perftest_support.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M ipc/ipc_test_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_test_base.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (16 generated)
Ken Rockot(use gerrit already)
4 years, 5 months ago (2016-07-19 17:15:47 UTC) #5
Ken Rockot(use gerrit already)
Actually I think I managed to do this without all this crap plumbing. Please ignore.
4 years, 5 months ago (2016-07-19 17:43:31 UTC) #10
Ken Rockot(use gerrit already)
I lied. This needs to be done after all. Please take a look!
4 years, 5 months ago (2016-07-19 19:13:18 UTC) #11
Ken Rockot(use gerrit already)
BTW the CL which uses this is https://codereview.chromium.org/2163633003 which completes Channel- (and ChannelProxy-) associated interface ...
4 years, 5 months ago (2016-07-19 21:18:42 UTC) #12
jam
lgtm, with addition of dcheck in channelproxy that the task runner it gets is the ...
4 years, 5 months ago (2016-07-19 21:40:08 UTC) #13
Ken Rockot(use gerrit already)
done
4 years, 5 months ago (2016-07-19 22:04:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159293002/40001
4 years, 5 months ago (2016-07-19 23:03:40 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/106875)
4 years, 5 months ago (2016-07-20 01:03:31 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159293002/40001
4 years, 5 months ago (2016-07-20 02:37:15 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 04:28:47 UTC) #25
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 04:28:53 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 04:30:56 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a34707ca8e2548fcc804ffaa9571adcba2d024a8
Cr-Commit-Position: refs/heads/master@{#406486}

Powered by Google App Engine
This is Rietveld 408576698