Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: ipc/ipc_channel.h

Issue 2159293002: Plumb explicit IPC task runner through to IPC::Channel creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add dcheck Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/render_thread_impl_browser_test_ipc_helper.cc ('k') | ipc/ipc_channel_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel.h
diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h
index 5c4b82fe981be61861dae7350a8a6719c8bb5b6c..8d886b51f19d3ea410a9eddd655051f395b3caed 100644
--- a/ipc/ipc_channel.h
+++ b/ipc/ipc_channel.h
@@ -16,6 +16,7 @@
#include "base/memory/ref_counted.h"
#include "base/process/process.h"
#include "base/single_thread_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
#include "build/build_config.h"
#include "ipc/ipc_channel_handle.h"
#include "ipc/ipc_endpoint.h"
@@ -185,8 +186,6 @@ class IPC_EXPORT Channel : public Endpoint {
// connects to the already established IPC object.
//
// Each mode has its own Create*() API to create the Channel object.
- //
- // TODO(morrita): Replace CreateByModeForProxy() with one of above Create*().
static std::unique_ptr<Channel> Create(
const IPC::ChannelHandle& channel_handle,
Mode mode,
@@ -194,7 +193,9 @@ class IPC_EXPORT Channel : public Endpoint {
static std::unique_ptr<Channel> CreateClient(
const IPC::ChannelHandle& channel_handle,
- Listener* listener);
+ Listener* listener,
+ const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner =
+ base::ThreadTaskRunnerHandle::Get());
// Channels on Windows are named by default and accessible from other
// processes. On POSIX channels are anonymous by default and not accessible
@@ -209,7 +210,9 @@ class IPC_EXPORT Channel : public Endpoint {
Listener* listener);
static std::unique_ptr<Channel> CreateServer(
const IPC::ChannelHandle& channel_handle,
- Listener* listener);
+ Listener* listener,
+ const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner =
+ base::ThreadTaskRunnerHandle::Get());
~Channel() override;
« no previous file with comments | « content/test/render_thread_impl_browser_test_ipc_helper.cc ('k') | ipc/ipc_channel_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698