Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: components/exo/gamepad.h

Issue 2159283002: exo: Fix crash in out-of-order destruction of Gamepad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/exo/gamepad.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/gamepad.h
diff --git a/components/exo/gamepad.h b/components/exo/gamepad.h
index 578a8d12fd9be800bf322c6838992f3dd26b751b..020a23d9494cdf79cdde7de7252540d4a129244b 100644
--- a/components/exo/gamepad.h
+++ b/components/exo/gamepad.h
@@ -30,11 +30,11 @@ class Gamepad : public aura::client::FocusChangeObserver {
// This class will post tasks to invoke the delegate on the thread runner
// which is associated with the thread that is creating this instance.
Gamepad(GamepadDelegate* delegate,
- base::SingleThreadTaskRunner* polling_task_runner);
+ scoped_refptr<base::SingleThreadTaskRunner> polling_task_runner);
reveman 2016/07/19 17:16:53 This just adds ref-count churn. Passing a raw poin
// Allows test cases to specify a CreateGamepadDataFetcherCallback that
// overrides the default GamepadPlatformDataFetcher.
Gamepad(GamepadDelegate* delegate,
- base::SingleThreadTaskRunner* polling_task_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> polling_task_runner,
reveman 2016/07/19 17:16:53 ditto
CreateGamepadDataFetcherCallback create_fetcher_callback);
~Gamepad() override;
« no previous file with comments | « no previous file | components/exo/gamepad.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698