Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2159273004: Added helper function to automatically dirty a RenderingScheduler on attribute change (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added helper function to automatically dirty a RenderingScheduler on attribute change R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/bc14cab5aa77875565ba43b1f7351572167e9111

Patch Set 1 #

Patch Set 2 : Added comments to new helper method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -58 lines) Patch
M runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/menu.dart View 1 chunk +3 lines, -25 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/menu_item.dart View 1 chunk +2 lines, -16 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/refresh.dart View 1 chunk +2 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-20 17:48:36 UTC) #2
Cutch
Nice! LGTM
4 years, 5 months ago (2016-07-20 17:50:59 UTC) #3
cbernaschina
4 years, 5 months ago (2016-07-20 17:55:37 UTC) #4
cbernaschina
4 years, 5 months ago (2016-07-20 19:47:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bc14cab5aa77875565ba43b1f7351572167e9111 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698