Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart

Issue 2159273004: Added helper function to automatically dirty a RenderingScheduler on attribute change (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Added comments to new helper method Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/nav/menu.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart
diff --git a/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart b/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart
index da3539ef7c0f88bed37e4f4642281f0c63c9bf3f..562d04b4521bef4e8f5e48703715884da5e3df45 100644
--- a/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart
+++ b/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart
@@ -75,6 +75,15 @@ class RenderingScheduler<T extends Renderable> implements RenderingTask {
scheduleRendering();
}
+ /// Checks for modification during attribute set.
+ /// If value changes a new rendering is scheduled.
+ /// set attr(T v) => _attr = _r.checkAndReact(_attr, v);
+ dynamic checkAndReact(dynamic oldValue, dynamic newValue) {
+ if (oldValue != newValue) dirty();
+ else scheduleNotification();
+ return newValue;
+ }
+
/// Schedules a new rendering phase.
void scheduleRendering() {
if (_renderingScheduled) return;
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/nav/menu.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698