Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: tools/perf/page_sets/system_health/browsing_stories.py

Issue 2159253002: [system health] Fix load:news:washingtonpost and browse:news:washingtonpost on Nexus9. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename variable Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/system_health/browsing_stories.py
diff --git a/tools/perf/page_sets/system_health/browsing_stories.py b/tools/perf/page_sets/system_health/browsing_stories.py
index 388e0ee5c3ea0c46d6988163c40715dbe8192216..520c1d09ee552e1ec46393f4c7e84e48d1923e5b 100644
--- a/tools/perf/page_sets/system_health/browsing_stories.py
+++ b/tools/perf/page_sets/system_health/browsing_stories.py
@@ -182,6 +182,13 @@ class WashingtonPostMobileStory(_NewsBrowsingStory):
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
def _DidLoadDocument(self, action_runner):
- # Close the popup window.
- action_runner.ClickElement(selector='.close')
+ # Close the popup window. On Nexus 9 (and probably other tables) the popup
+ # window does not have a "Close" button, instead it has only a "Send link
+ # to phone" button. So on tablets we run with the popup window open. The
+ # popup is transparent, so this is mostly an aesthetical issue.
+ buttonSelector = '.close'
petrcermak 2016/07/19 17:41:24 button_selector. Furthermore, this could be a clas
ulan 2016/07/19 17:48:55 Done.
+ hasButton = action_runner.EvaluateJavaScript(
petrcermak 2016/07/19 17:41:24 has_button
ulan 2016/07/19 17:48:55 Done.
+ '!!document.querySelector("%s")' % buttonSelector)
+ if hasButton:
+ action_runner.ClickElement(selector=buttonSelector)
super(WashingtonPostMobileStory, self)._DidLoadDocument(action_runner)

Powered by Google App Engine
This is Rietveld 408576698