Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: tools/perf/page_sets/system_health/browsing_stories.py

Issue 2159253002: [system health] Fix load:news:washingtonpost and browse:news:washingtonpost on Nexus9. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename variable Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from page_sets.system_health import platforms 5 from page_sets.system_health import platforms
6 from page_sets.system_health import system_health_story 6 from page_sets.system_health import system_health_story
7 7
8 8
9 class _BrowsingStory(system_health_story.SystemHealthStory): 9 class _BrowsingStory(system_health_story.SystemHealthStory):
10 """Abstract base class for browsing stories. 10 """Abstract base class for browsing stories.
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 175
176 class WashingtonPostMobileStory(_NewsBrowsingStory): 176 class WashingtonPostMobileStory(_NewsBrowsingStory):
177 """Progressive website""" 177 """Progressive website"""
178 NAME = 'browse:news:washingtonpost' 178 NAME = 'browse:news:washingtonpost'
179 URL = 'https://www.washingtonpost.com/pwa' 179 URL = 'https://www.washingtonpost.com/pwa'
180 IS_SINGLE_PAGE_APP = True 180 IS_SINGLE_PAGE_APP = True
181 ITEM_SELECTOR = '.hed > a' 181 ITEM_SELECTOR = '.hed > a'
182 SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY 182 SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
183 183
184 def _DidLoadDocument(self, action_runner): 184 def _DidLoadDocument(self, action_runner):
185 # Close the popup window. 185 # Close the popup window. On Nexus 9 (and probably other tables) the popup
186 action_runner.ClickElement(selector='.close') 186 # window does not have a "Close" button, instead it has only a "Send link
187 # to phone" button. So on tablets we run with the popup window open. The
188 # popup is transparent, so this is mostly an aesthetical issue.
189 buttonSelector = '.close'
petrcermak 2016/07/19 17:41:24 button_selector. Furthermore, this could be a clas
ulan 2016/07/19 17:48:55 Done.
190 hasButton = action_runner.EvaluateJavaScript(
petrcermak 2016/07/19 17:41:24 has_button
ulan 2016/07/19 17:48:55 Done.
191 '!!document.querySelector("%s")' % buttonSelector)
192 if hasButton:
193 action_runner.ClickElement(selector=buttonSelector)
187 super(WashingtonPostMobileStory, self)._DidLoadDocument(action_runner) 194 super(WashingtonPostMobileStory, self)._DidLoadDocument(action_runner)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698