gpu/command_buffer/service/framebuffer_manager.h - Issue 2159183002: Attaching an image to many color attachment points is unsupported

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/framebuffer_manager.h

Issue 2159183002: Attaching an image to many color attachment points is unsupported (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove webgl2 condition Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | gpu/command_buffer/service/framebuffer_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/framebuffer_manager.h

diff --git a/gpu/command_buffer/service/framebuffer_manager.h b/gpu/command_buffer/service/framebuffer_manager.h

index e489536aa438d2a501bf207da6b1f36312b8d190..edf9afd5fc75b5b05c5891b8e6d58d623b483a0c 100644

--- a/gpu/command_buffer/service/framebuffer_manager.h

+++ b/gpu/command_buffer/service/framebuffer_manager.h

@@ -51,8 +51,8 @@ class GPU_EXPORT Framebuffer : public base::RefCounted<Framebuffer> {

virtual bool IsTextureAttachment() const = 0;

virtual bool IsRenderbufferAttachment() const = 0;

virtual bool IsTexture(TextureRef* texture) const = 0;

- virtual bool IsRenderbuffer(

- Renderbuffer* renderbuffer) const = 0;

+ virtual bool IsRenderbuffer(Renderbuffer* renderbuffer) const = 0;

+ virtual bool IsSameAttachment(const Attachment* attachment) const = 0;

virtual bool Is3D() const = 0;

// If it's a 3D texture attachment, return true if