Attaching an image to many color attachment points is unsupported

gpu/command_buffer/service/framebuffer_manager_unittest.cc

Index: gpu/command_buffer/service/framebuffer_manager_unittest.cc
diff --git a/gpu/command_buffer/service/framebuffer_manager_unittest.cc b/gpu/command_buffer/service/framebuffer_manager_unittest.cc
index 6c7dde58261145b95c7f1553574bcfe70d39eda1..1679fb979932a54f5b9aff1cf32713b799ad3480 100644
--- a/gpu/command_buffer/service/framebuffer_manager_unittest.cc
+++ b/gpu/command_buffer/service/framebuffer_manager_unittest.cc
@@ -1491,6 +1491,28 @@ TEST_F(FramebufferInfoTest, GetStatus) {
   framebuffer_->GetStatus(texture_manager_.get(), GL_READ_FRAMEBUFFER);
 }
 
+TEST_F(FramebufferInfoTest, HasDuplicateColorAttachments) {

[Zhenyao Mo, 2016/07/19 20:39:15]

nit: HasDuplicatedAttachments

[qiankun, 2016/07/20 08:53:33]

Done.

+  const GLuint kTextureClientId = 33;
+  const GLuint kTextureServiceId = 333;
+  const GLenum kTarget = GL_TEXTURE_2D;
+  const GLint kLevel = 0;
+  const GLint kSamples = 0;
+
+  texture_manager_->CreateTexture(kTextureClientId, kTextureServiceId);
+  scoped_refptr<TextureRef> texture(
+      texture_manager_->GetTexture(kTextureClientId));
+  ASSERT_TRUE(texture.get() != NULL);

[Zhenyao Mo, 2016/07/19 20:39:15]

nit: nullptr

[qiankun, 2016/07/20 08:53:33]

Done.

BTW:
These are many "NULL" under src/gpu/. Should we clean them?

+  texture_manager_->SetTarget(texture.get(), GL_TEXTURE_2D);
+
+  // Check an image is attached to more than one color attachment point
+  // in a framebuffer.
+  framebuffer_->AttachTexture(
+      GL_COLOR_ATTACHMENT0, texture.get(), kTarget, kLevel, kSamples);
+  framebuffer_->AttachTexture(
+      GL_COLOR_ATTACHMENT1, texture.get(), kTarget, kLevel, kSamples);
+  EXPECT_TRUE(framebuffer_->HasDuplicateColorAttachments());
+}
+
 class FramebufferInfoES3Test : public FramebufferInfoTestBase {
  public:
   FramebufferInfoES3Test() : FramebufferInfoTestBase(CONTEXT_TYPE_WEBGL2) {}