Attaching an image to many color attachment points is unsupported

gpu/command_buffer/service/framebuffer_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "gpu/command_buffer/service/error_state_mock.h"
 #include "gpu/command_buffer/service/feature_info.h"
 #include "gpu/command_buffer/service/framebuffer_manager.h"
@@ skipping 1473 matching lines @@
                                                GL_TEXTURE_WRAP_S,
                                                GL_REPEAT,
                                                GL_NO_ERROR);
   framebuffer_->GetStatus(texture_manager_.get(), GL_READ_FRAMEBUFFER);
 
   // Check Unbinding does not call CheckFramebufferStatus
   framebuffer_->UnbindRenderbuffer(GL_RENDERBUFFER, renderbuffer1);
   framebuffer_->GetStatus(texture_manager_.get(), GL_READ_FRAMEBUFFER);
 }
 
+TEST_F(FramebufferInfoTest, HasDuplicateColorAttachments) {

[Zhenyao Mo, 2016/07/19 20:39:15]

nit: HasDuplicatedAttachments

[qiankun, 2016/07/20 08:53:33]

Done.

+  const GLuint kTextureClientId = 33;
+  const GLuint kTextureServiceId = 333;
+  const GLenum kTarget = GL_TEXTURE_2D;
+  const GLint kLevel = 0;
+  const GLint kSamples = 0;
+
+  texture_manager_->CreateTexture(kTextureClientId, kTextureServiceId);
+  scoped_refptr<TextureRef> texture(
+      texture_manager_->GetTexture(kTextureClientId));
+  ASSERT_TRUE(texture.get() != NULL);

[Zhenyao Mo, 2016/07/19 20:39:15]

nit: nullptr

[qiankun, 2016/07/20 08:53:33]

Done.

BTW:
These are many "NULL" under src/gpu/. Should we clean them?

+  texture_manager_->SetTarget(texture.get(), GL_TEXTURE_2D);
+
+  // Check an image is attached to more than one color attachment point
+  // in a framebuffer.
+  framebuffer_->AttachTexture(
+      GL_COLOR_ATTACHMENT0, texture.get(), kTarget, kLevel, kSamples);
+  framebuffer_->AttachTexture(
+      GL_COLOR_ATTACHMENT1, texture.get(), kTarget, kLevel, kSamples);
+  EXPECT_TRUE(framebuffer_->HasDuplicateColorAttachments());
+}
+
 class FramebufferInfoES3Test : public FramebufferInfoTestBase {
  public:
   FramebufferInfoES3Test() : FramebufferInfoTestBase(CONTEXT_TYPE_WEBGL2) {}
 };
 
 TEST_F(FramebufferInfoES3Test, DifferentDimensions) {
   const GLuint kRenderbufferClient1Id = 33;
   const GLuint kRenderbufferService1Id = 333;
   const GLuint kRenderbufferClient2Id = 34;
   const GLuint kRenderbufferService2Id = 334;
@@ skipping 53 matching lines @@
       renderbuffer_manager_->GetRenderbuffer(kRenderbufferClientId);
   ASSERT_TRUE(renderbuffer != NULL);
   framebuffer_->AttachRenderbuffer(GL_COLOR_ATTACHMENT1, renderbuffer);
   EXPECT_TRUE(framebuffer_->GetReadBufferAttachment());
 }
 
 }  // namespace gles2
 }  // namespace gpu