Shutdown StoragePartition before ProfileIOData is being shut down

chrome/browser/profiles/profile_impl_io_data.cc

Index: chrome/browser/profiles/profile_impl_io_data.cc
diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc
index 04a4e743c55215d95a3b5fb434fb18f3c45b455b..16e4694b36ae98b947a80f61c9ab314fdbb3d111 100644
--- a/chrome/browser/profiles/profile_impl_io_data.cc
+++ b/chrome/browser/profiles/profile_impl_io_data.cc
@@ -116,6 +116,8 @@ ProfileImplIOData::Handle::Handle(Profile* profile)
 
 ProfileImplIOData::Handle::~Handle() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
+  profile_->ShutdownStoragePartitions();

[mmenke, 2016/07/19 17:55:20]

This doesn't seem like a good place for this - this method is implicitly called
during ProfileImpl's destructor, and calling a Profile method from an implicitly
called destructor seems like a bad idea.

I don't suppose we can just explicitly call ShutdownStoragePartitions() at the
end of ProfileImpl's destructor instead?

[kinuko, 2016/07/21 03:06:25]

I think we can, and yeah that'd be better. Done.

I wanted to have some assertion to make sure we call ShutdownStoragePartitions
before IOData::ShutdownOnUIThread, but don't have a good idea (other than adding
a flag).  Added comments instead.

+
   if (io_data_->predictor_ != NULL) {
     // io_data_->predictor_ might be NULL if Init() was never called
     // (i.e. we shut down before ProfileImpl::DoFinalInit() got called).