Shutdown StoragePartition before ProfileIOData is being shut down

chrome/browser/profiles/profile_impl_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl_io_data.h"
 
 #include <memory>
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 98 matching lines @@
 ProfileImplIOData::Handle::Handle(Profile* profile)
     : io_data_(new ProfileImplIOData),
       profile_(profile),
       initialized_(false) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   DCHECK(profile);
 }
 
 ProfileImplIOData::Handle::~Handle() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
+  profile_->ShutdownStoragePartitions();

[mmenke, 2016/07/19 17:55:20]

This doesn't seem like a good place for this - this method is implicitly called
during ProfileImpl's destructor, and calling a Profile method from an implicitly
called destructor seems like a bad idea.

I don't suppose we can just explicitly call ShutdownStoragePartitions() at the
end of ProfileImpl's destructor instead?

[kinuko, 2016/07/21 03:06:25]

I think we can, and yeah that'd be better. Done.

I wanted to have some assertion to make sure we call ShutdownStoragePartitions
before IOData::ShutdownOnUIThread, but don't have a good idea (other than adding
a flag).  Added comments instead.

+
   if (io_data_->predictor_ != NULL) {
     // io_data_->predictor_ might be NULL if Init() was never called
     // (i.e. we shut down before ProfileImpl::DoFinalInit() got called).
     bool save_prefs = true;
 #if defined(OS_CHROMEOS)
     save_prefs = !chromeos::ProfileHelper::IsSigninProfile(profile_);
 #endif
     if (save_prefs)
       io_data_->predictor_->SaveStateForNextStartup();
     io_data_->predictor_->ShutdownOnUIThread();
@@ skipping 663 matching lines @@
     const base::Closure& completion) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   DCHECK(initialized());
 
   DCHECK(transport_security_state());
   // Completes synchronously.
   transport_security_state()->DeleteAllDynamicDataSince(time);
   DCHECK(http_server_properties_manager_);
   http_server_properties_manager_->Clear(completion);
 }