Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Issue 215903003: Autofill/rAc: dispatch "input" events when changing text contents of <textarea>, (Closed)

Created:
6 years, 9 months ago by Dan Beam
Modified:
6 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, dglazkov+blink, adamk+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Autofill/rAc: dispatch "input" events when changing text contents of <textarea>, <select>, or <input> tags via Autofill. This more closely matches the spec behavior as "input" events should be fired whenever the text is changed. From the spec[1]: """ When the user agent is to change an input element's value on behalf of the user (e.g. as part of a form prefilling feature), the user agent must queue a task to first update the value accordingly, then fire a simple event that bubbles named input at the input element, then fire a simple event that bubbles named change at the input element. """ BUG=353691 R=tkent@chromium.org [1] http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#event-input-input Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170278

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove dispatchFormControl*Event() #

Patch Set 3 : add back dispatchFormControlChangeEvent() temporarily to not break chrome when blink gets rolled in #

Total comments: 4

Patch Set 4 : protecting protectors everywhere #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -40 lines) Patch
M Source/core/html/HTMLInputElement.cpp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 chunks +22 lines, -17 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 2 3 3 chunks +14 lines, -6 lines 0 comments Download
M Source/web/WebFormControlElement.cpp View 1 2 3 chunks +9 lines, -9 lines 0 comments Download
M Source/web/WebInputElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebFormControlElement.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M public/web/WebInputElement.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Dan Beam
this patch fixes behavior for <input> elements and adds an API to WebFormControlElement which is ...
6 years, 9 months ago (2014-03-28 01:38:19 UTC) #1
tkent
https://codereview.chromium.org/215903003/diff/1/Source/core/html/HTMLInputElement.cpp File Source/core/html/HTMLInputElement.cpp (right): https://codereview.chromium.org/215903003/diff/1/Source/core/html/HTMLInputElement.cpp#newcode887 Source/core/html/HTMLInputElement.cpp:887: dispatchFormControlInputEvent(); Looks dangerous. An 'input' event handler can delete ...
6 years, 9 months ago (2014-03-28 01:50:33 UTC) #2
Dan Beam
https://codereview.chromium.org/215903003/diff/1/Source/core/html/HTMLInputElement.cpp File Source/core/html/HTMLInputElement.cpp (right): https://codereview.chromium.org/215903003/diff/1/Source/core/html/HTMLInputElement.cpp#newcode887 Source/core/html/HTMLInputElement.cpp:887: dispatchFormControlInputEvent(); On 2014/03/28 01:50:33, tkent wrote: > Looks dangerous. ...
6 years, 9 months ago (2014-03-28 04:50:56 UTC) #3
Dan Beam
this shortens/simplifies the Chrome-side code significantly, ex: https://codereview.chromium.org/214823011/diff2/1:20001/components/autofill/content/renderer/form_autofill_util.cc
6 years, 9 months ago (2014-03-28 04:57:51 UTC) #4
tkent
lgtm https://codereview.chromium.org/215903003/diff/50001/Source/core/html/HTMLTextAreaElement.cpp File Source/core/html/HTMLTextAreaElement.cpp (right): https://codereview.chromium.org/215903003/diff/50001/Source/core/html/HTMLTextAreaElement.cpp#newcode342 Source/core/html/HTMLTextAreaElement.cpp:342: setValueCommon(value, eventBehavior); This function needs "RefPtr<HTMLTextAreaElement> protector(this)". https://codereview.chromium.org/215903003/diff/50001/Source/core/html/HTMLTextAreaElement.cpp#newcode367 ...
6 years, 9 months ago (2014-03-28 04:58:48 UTC) #5
Dan Beam
https://codereview.chromium.org/215903003/diff/50001/Source/core/html/HTMLTextAreaElement.cpp File Source/core/html/HTMLTextAreaElement.cpp (right): https://codereview.chromium.org/215903003/diff/50001/Source/core/html/HTMLTextAreaElement.cpp#newcode342 Source/core/html/HTMLTextAreaElement.cpp:342: setValueCommon(value, eventBehavior); On 2014/03/28 04:58:48, tkent wrote: > This ...
6 years, 9 months ago (2014-03-28 05:03:47 UTC) #6
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 9 months ago (2014-03-28 05:04:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/215903003/70001
6 years, 9 months ago (2014-03-28 05:04:04 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 05:14:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-28 05:14:47 UTC) #10
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 9 months ago (2014-03-28 05:17:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/215903003/70001
6 years, 9 months ago (2014-03-28 05:17:14 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 06:12:43 UTC) #13
Message was sent while issue was closed.
Change committed as 170278

Powered by Google App Engine
This is Rietveld 408576698