Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 215903003: Autofill/rAc: dispatch "input" events when changing text contents of <textarea>, (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/web/WebFormControlElement.cpp » ('j') | public/web/WebFormControlElement.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 865 matching lines...) Expand 10 before | Expand all | Expand 10 after
876 cache->checkedStateChanged(this); 876 cache->checkedStateChanged(this);
877 } 877 }
878 878
879 // Only send a change event for items in the document (avoid firing during 879 // Only send a change event for items in the document (avoid firing during
880 // parsing) and don't send a change event for a radio button that's getting 880 // parsing) and don't send a change event for a radio button that's getting
881 // unchecked to match other browsers. DOM is not a useful standard for this 881 // unchecked to match other browsers. DOM is not a useful standard for this
882 // because it says only to fire change events at "lose focus" time, which is 882 // because it says only to fire change events at "lose focus" time, which is
883 // definitely wrong in practice for these types of elements. 883 // definitely wrong in practice for these types of elements.
884 if (eventBehavior != DispatchNoEvent && inDocument() && m_inputType->shouldS endChangeEventAfterCheckedChanged()) { 884 if (eventBehavior != DispatchNoEvent && inDocument() && m_inputType->shouldS endChangeEventAfterCheckedChanged()) {
885 setTextAsOfLastFormControlChangeEvent(String()); 885 setTextAsOfLastFormControlChangeEvent(String());
886 if (eventBehavior == DispatchInputAndChangeEvent)
887 dispatchFormControlInputEvent();
tkent 2014/03/28 01:50:33 Looks dangerous. An 'input' event handler can del
Dan Beam 2014/03/28 04:50:57 Done.
886 dispatchFormControlChangeEvent(); 888 dispatchFormControlChangeEvent();
887 } 889 }
888 890
889 didAffectSelector(AffectedSelectorChecked); 891 didAffectSelector(AffectedSelectorChecked);
890 } 892 }
891 893
892 void HTMLInputElement::setIndeterminate(bool newValue) 894 void HTMLInputElement::setIndeterminate(bool newValue)
893 { 895 {
894 if (indeterminate() == newValue) 896 if (indeterminate() == newValue)
895 return; 897 return;
(...skipping 982 matching lines...) Expand 10 before | Expand all | Expand 10 after
1878 } 1880 }
1879 1881
1880 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 1882 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
1881 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer() 1883 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
1882 { 1884 {
1883 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer()); 1885 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());
1884 } 1886 }
1885 #endif 1887 #endif
1886 1888
1887 } // namespace 1889 } // namespace
OLDNEW
« no previous file with comments | « no previous file | Source/web/WebFormControlElement.cpp » ('j') | public/web/WebFormControlElement.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698