Read Chrome build ID and store it in leak reports

chrome/browser/metrics/leak_detector/leak_detector_controller.cc

Index: chrome/browser/metrics/leak_detector/leak_detector_controller.cc
diff --git a/chrome/browser/metrics/leak_detector/leak_detector_controller.cc b/chrome/browser/metrics/leak_detector/leak_detector_controller.cc
index a95597b27bd6a824d18e2b1f363ef4749b5184ce..5b1d28f6a09943dc5704e0cc8d7b42fb553c98e0 100644
--- a/chrome/browser/metrics/leak_detector/leak_detector_controller.cc
+++ b/chrome/browser/metrics/leak_detector/leak_detector_controller.cc
@@ -8,6 +8,7 @@
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
+#include "components/metrics/leak_detector/gnu_build_id_reader.h"
 #include "components/variations/variations_associated_data.h"
 #include "content/public/browser/browser_thread.h"
 
@@ -90,6 +91,9 @@ MemoryLeakReportProto::Params GetVariationParameters() {
 
 LeakDetectorController::LeakDetectorController()
     : params_(GetVariationParameters()) {
+  // Read the build ID once and store it.
+  DCHECK(leak_detector::gnu_build_id_reader::ReadBuildID(&build_id_));

[rickyz (no longer on Chrome), 2016/07/19 04:58:22]

If you rely on side effects of a function, don't put it in a DCHECK - on builds
that disable these, this call will be dropped.

[Simon Que, 2016/07/22 01:40:06]

Done.

+
   LeakDetector* detector = LeakDetector::GetInstance();
   detector->AddObserver(this);
 
@@ -111,6 +115,8 @@ void LeakDetectorController::OnLeaksFound(
     // Store the report and insert stored parameters.
     stored_reports_.push_back(report);
     stored_reports_.back().mutable_params()->CopyFrom(params_);
+    stored_reports_.back().mutable_build_id()->assign(build_id_.begin(),
+                                                      build_id_.end());
   }
 }