Read Chrome build ID and store it in leak reports

chrome/browser/metrics/leak_detector/leak_detector_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/leak_detector/leak_detector_controller.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
+#include "components/metrics/leak_detector/gnu_build_id_reader.h"
 #include "components/variations/variations_associated_data.h"
 #include "content/public/browser/browser_thread.h"
 
 namespace metrics {
 
 namespace {
 
 // Reads parameters for the field trial variation. Any parameters not present in
 // the variation info or that cannot be parsed will be filled in with default
 // values. Returns a MemoryLeakReportProto with the parameter fields filled in.
@@ skipping 62 matching lines @@
   result.set_analysis_interval_bytes(analysis_interval_kb * 1024);
   result.set_size_suspicion_threshold(size_suspicion_threshold);
   result.set_call_stack_suspicion_threshold(call_stack_suspicion_threshold);
   return result;
 }
 
 }  // namespace
 
 LeakDetectorController::LeakDetectorController()
     : params_(GetVariationParameters()) {
+  // Read the build ID once and store it.
+  DCHECK(leak_detector::gnu_build_id_reader::ReadBuildID(&build_id_));

[rickyz (no longer on Chrome), 2016/07/19 04:58:22]

If you rely on side effects of a function, don't put it in a DCHECK - on builds
that disable these, this call will be dropped.

[Simon Que, 2016/07/22 01:40:06]

Done.

+
   LeakDetector* detector = LeakDetector::GetInstance();
   detector->AddObserver(this);
 
   // Leak detector parameters are stored in |params_|.
   detector->Init(params_, content::BrowserThread::GetTaskRunnerForThread(
                               content::BrowserThread::UI));
 }
 
 LeakDetectorController::~LeakDetectorController() {
   DCHECK(thread_checker_.CalledOnValidThread());
   LeakDetector::GetInstance()->RemoveObserver(this);
 }
 
 void LeakDetectorController::OnLeaksFound(
     const std::vector<MemoryLeakReportProto>& reports) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   for (const auto& report : reports) {
     // Store the report and insert stored parameters.
     stored_reports_.push_back(report);
     stored_reports_.back().mutable_params()->CopyFrom(params_);
+    stored_reports_.back().mutable_build_id()->assign(build_id_.begin(),
+                                                      build_id_.end());
   }
 }
 
 void LeakDetectorController::GetLeakReports(
     std::vector<MemoryLeakReportProto>* reports) {
   DCHECK(thread_checker_.CalledOnValidThread());
   *reports = std::move(stored_reports_);
 }
 
 }  // namespace metrics