Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Unified Diff: chrome/browser/metrics/leak_detector/leak_detector_controller.cc

Issue 2159013002: Read Chrome build ID and store it in leak reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/leak_detector/leak_detector_controller.cc
diff --git a/chrome/browser/metrics/leak_detector/leak_detector_controller.cc b/chrome/browser/metrics/leak_detector/leak_detector_controller.cc
index a95597b27bd6a824d18e2b1f363ef4749b5184ce..0f26b8cbd34ec73e16fe267604d46516dca3f044 100644
--- a/chrome/browser/metrics/leak_detector/leak_detector_controller.cc
+++ b/chrome/browser/metrics/leak_detector/leak_detector_controller.cc
@@ -8,6 +8,7 @@
#include "base/logging.h"
#include "base/strings/string_number_conversions.h"
+#include "components/metrics/leak_detector/gnu_build_id_reader.h"
#include "components/variations/variations_associated_data.h"
#include "content/public/browser/browser_thread.h"
@@ -90,6 +91,11 @@ MemoryLeakReportProto::Params GetVariationParameters() {
LeakDetectorController::LeakDetectorController()
: params_(GetVariationParameters()) {
+ // Read the build ID once and store it.
+ leak_detector::GNUBuildIDReader build_id_reader;
+ build_id_reader.ReadBuildID();
+ build_id_ = build_id_reader.build_id();
+
LeakDetector* detector = LeakDetector::GetInstance();
detector->AddObserver(this);
@@ -111,6 +117,8 @@ void LeakDetectorController::OnLeaksFound(
// Store the report and insert stored parameters.
stored_reports_.push_back(report);
stored_reports_.back().mutable_params()->CopyFrom(params_);
+ stored_reports_.back().mutable_build_id()->assign(build_id_.begin(),
+ build_id_.end());
}
}

Powered by Google App Engine
This is Rietveld 408576698