Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/metrics/leak_detector/leak_detector_controller.cc

Issue 2159013002: Read Chrome build ID and store it in leak reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/leak_detector/leak_detector_controller.h" 5 #include "chrome/browser/metrics/leak_detector/leak_detector_controller.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "components/metrics/leak_detector/gnu_build_id_reader.h"
11 #include "components/variations/variations_associated_data.h" 12 #include "components/variations/variations_associated_data.h"
12 #include "content/public/browser/browser_thread.h" 13 #include "content/public/browser/browser_thread.h"
13 14
14 namespace metrics { 15 namespace metrics {
15 16
16 namespace { 17 namespace {
17 18
18 // Reads parameters for the field trial variation. Any parameters not present in 19 // Reads parameters for the field trial variation. Any parameters not present in
19 // the variation info or that cannot be parsed will be filled in with default 20 // the variation info or that cannot be parsed will be filled in with default
20 // values. Returns a MemoryLeakReportProto with the parameter fields filled in. 21 // values. Returns a MemoryLeakReportProto with the parameter fields filled in.
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 result.set_analysis_interval_bytes(analysis_interval_kb * 1024); 84 result.set_analysis_interval_bytes(analysis_interval_kb * 1024);
84 result.set_size_suspicion_threshold(size_suspicion_threshold); 85 result.set_size_suspicion_threshold(size_suspicion_threshold);
85 result.set_call_stack_suspicion_threshold(call_stack_suspicion_threshold); 86 result.set_call_stack_suspicion_threshold(call_stack_suspicion_threshold);
86 return result; 87 return result;
87 } 88 }
88 89
89 } // namespace 90 } // namespace
90 91
91 LeakDetectorController::LeakDetectorController() 92 LeakDetectorController::LeakDetectorController()
92 : params_(GetVariationParameters()) { 93 : params_(GetVariationParameters()) {
94 // Read the build ID once and store it.
95 leak_detector::GNUBuildIDReader build_id_reader;
96 build_id_reader.ReadBuildID();
97 build_id_ = build_id_reader.build_id();
98
93 LeakDetector* detector = LeakDetector::GetInstance(); 99 LeakDetector* detector = LeakDetector::GetInstance();
94 detector->AddObserver(this); 100 detector->AddObserver(this);
95 101
96 // Leak detector parameters are stored in |params_|. 102 // Leak detector parameters are stored in |params_|.
97 detector->Init(params_, content::BrowserThread::GetTaskRunnerForThread( 103 detector->Init(params_, content::BrowserThread::GetTaskRunnerForThread(
98 content::BrowserThread::UI)); 104 content::BrowserThread::UI));
99 } 105 }
100 106
101 LeakDetectorController::~LeakDetectorController() { 107 LeakDetectorController::~LeakDetectorController() {
102 DCHECK(thread_checker_.CalledOnValidThread()); 108 DCHECK(thread_checker_.CalledOnValidThread());
103 LeakDetector::GetInstance()->RemoveObserver(this); 109 LeakDetector::GetInstance()->RemoveObserver(this);
104 } 110 }
105 111
106 void LeakDetectorController::OnLeaksFound( 112 void LeakDetectorController::OnLeaksFound(
107 const std::vector<MemoryLeakReportProto>& reports) { 113 const std::vector<MemoryLeakReportProto>& reports) {
108 DCHECK(thread_checker_.CalledOnValidThread()); 114 DCHECK(thread_checker_.CalledOnValidThread());
109 115
110 for (const auto& report : reports) { 116 for (const auto& report : reports) {
111 // Store the report and insert stored parameters. 117 // Store the report and insert stored parameters.
112 stored_reports_.push_back(report); 118 stored_reports_.push_back(report);
113 stored_reports_.back().mutable_params()->CopyFrom(params_); 119 stored_reports_.back().mutable_params()->CopyFrom(params_);
120 stored_reports_.back().mutable_build_id()->assign(build_id_.begin(),
121 build_id_.end());
114 } 122 }
115 } 123 }
116 124
117 void LeakDetectorController::GetLeakReports( 125 void LeakDetectorController::GetLeakReports(
118 std::vector<MemoryLeakReportProto>* reports) { 126 std::vector<MemoryLeakReportProto>* reports) {
119 DCHECK(thread_checker_.CalledOnValidThread()); 127 DCHECK(thread_checker_.CalledOnValidThread());
120 *reports = std::move(stored_reports_); 128 *reports = std::move(stored_reports_);
121 } 129 }
122 130
123 } // namespace metrics 131 } // namespace metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698