Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2158933003: Fix for uri replace whene uri has fragment. Was adding a second '#'. (Closed)

Created:
4 years, 5 months ago by keertip
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for uri replace whene uri has fragment. Was adding a second '#'. BUG= R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/69a8b11f6717d4cc8e55f9bc0123eac4f90db849

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M sdk/lib/core/uri.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/uri_test.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
keertip
4 years, 5 months ago (2016-07-18 22:00:06 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2158933003/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/2158933003/diff/1/sdk/lib/core/uri.dart#newcode4210 sdk/lib/core/uri.dart:4210: fragment = _uri.substring(_fragmentStart+1); nit: spaces around '+' https://codereview.chromium.org/2158933003/diff/1/tests/corelib/uri_test.dart ...
4 years, 5 months ago (2016-07-18 22:48:12 UTC) #3
keertip
https://codereview.chromium.org/2158933003/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/2158933003/diff/1/sdk/lib/core/uri.dart#newcode4210 sdk/lib/core/uri.dart:4210: fragment = _uri.substring(_fragmentStart+1); On 2016/07/18 22:48:12, Harry Terkelsen wrote: ...
4 years, 5 months ago (2016-07-18 23:29:32 UTC) #4
keertip
4 years, 5 months ago (2016-07-18 23:31:52 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
69a8b11f6717d4cc8e55f9bc0123eac4f90db849 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698