Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: sdk/lib/core/uri.dart

Issue 2158933003: Fix for uri replace whene uri has fragment. Was adding a second '#'. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/corelib/uri_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/core/uri.dart
diff --git a/sdk/lib/core/uri.dart b/sdk/lib/core/uri.dart
index 17f290d14e9be14108050c037aac48ff94348329..b43b3ad0474ac9f63d089f80ef196831297e2993 100644
--- a/sdk/lib/core/uri.dart
+++ b/sdk/lib/core/uri.dart
@@ -4207,7 +4207,7 @@ class _SimpleUri implements Uri {
if (fragment != null) {
fragment = _Uri._makeFragment(fragment, 0, fragment.length);
} else if (_fragmentStart < _uri.length) {
- fragment = _uri.substring(_fragmentStart);
+ fragment = _uri.substring(_fragmentStart + 1);
}
return new _Uri._internal(
« no previous file with comments | « no previous file | tests/corelib/uri_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698