Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely to protect against future bugs.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=620770, 624004
Committed: https://crrev.com/2830b0728b273d6fe15ecb28a1c27aa6cddd6c08
Cr-Commit-Position: refs/heads/master@{#406567}

[mmenke, 2016-07-18 22:28:58]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 22:29:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 00:00:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 00:00:04]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-07-19 00:25:27]

mmenke@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2016-07-20 07:31:35]

LGTM! Getting pretty close now. Thanks for this series of patches. :)

[mmenke, 2016-07-20 12:48:20]

Description was changed from

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes sorting the
source URL on cookies entirely.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=624004
==========

to

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely (Which is no longer used), to prevent
future regressions.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=624004
==========

[mmenke, 2016-07-20 14:45:14]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-07-20 14:45:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-07-20 14:46:12]

Description was changed from

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely (Which is no longer used), to prevent
future regressions.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=624004
==========

to

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely (Which is no longer used), to prevent
future regressions.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=620770,624004
==========

[mmenke, 2016-07-20 14:51:04]

Description was changed from

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely (Which is no longer used), to prevent
future regressions.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=620770,624004
==========

to

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely to prevent future regressions.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=620770,624004
==========

[mmenke, 2016-07-20 14:51:22]

Description was changed from

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely to prevent future regressions.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=620770,624004
==========

to

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely to protect against future bugs.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=620770,624004
==========

[commit-bot: I haz the power, 2016-07-20 16:03:05]

Description was changed from

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely to protect against future bugs.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=620770,624004
==========

to

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely to protect against future bugs.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=620770,624004
==========

[commit-bot: I haz the power, 2016-07-20 16:03:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-20 16:03:08]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 16:04:29]

Description was changed from

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely to protect against future bugs.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=620770,624004
==========

to

==========
Fix CanonicalCookie::IsEquivalentForSecureCookieMatching

This method relies on the Source() of a cookie, which is not set
consistently. In particular, it's not set on cookies that have been
loaded from disk. This CL fixes the method, and removes storing the
source URL on cookies entirely to protect against future bugs.

Since the new implementation of IsEquivalentForSecureCookieMatching is
a little more expensive, also reorder code to call it a bit less often.

BUG=620770,624004

Committed: https://crrev.com/2830b0728b273d6fe15ecb28a1c27aa6cddd6c08
Cr-Commit-Position: refs/heads/master@{#406567}
==========

[commit-bot: I haz the power, 2016-07-20 16:04:30]

Patchset 1 (id:??) landed as
https://crrev.com/2830b0728b273d6fe15ecb28a1c27aa6cddd6c08
Cr-Commit-Position: refs/heads/master@{#406567}