Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: net/cookies/cookie_monster.cc

Issue 2158863003: Fix CanonicalCookie::IsEquivalentForSecureCookieMatching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/canonical_cookie.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster.cc
diff --git a/net/cookies/cookie_monster.cc b/net/cookies/cookie_monster.cc
index 3b772f7b55ab5800ce514f974a2b29bc13e2d15f..1d38fc09acea414d1292160b0ebe24d0031cd616 100644
--- a/net/cookies/cookie_monster.cc
+++ b/net/cookies/cookie_monster.cc
@@ -1637,8 +1637,9 @@ bool CookieMonster::DeleteAnyEquivalentCookie(const std::string& key,
// ignoring the path attribute.
//
// See: https://tools.ietf.org/html/draft-west-leave-secure-cookies-alone
- if (enforce_strict_secure && !source_url.SchemeIsCryptographic() &&
- ecc.IsEquivalentForSecureCookieMatching(*cc) && cc->IsSecure()) {
+ if (enforce_strict_secure && cc->IsSecure() &&
+ !source_url.SchemeIsCryptographic() &&
+ ecc.IsEquivalentForSecureCookieMatching(*cc)) {
skipped_secure_cookie = true;
histogram_cookie_delete_equivalent_->Add(
COOKIE_DELETE_EQUIVALENT_SKIPPING_SECURE);
« no previous file with comments | « net/cookies/canonical_cookie.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698