Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2161803002: Add needsToolbarShadow to NativePage interface (Closed)

Created:
4 years, 5 months ago by mdjones
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer, Ted C
CC:
chromium-reviews, noyau+watch_chromium.org, browser-components-watch_chromium.org, ntp-dev+reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add needsToolbarShadow to NativePage interface This method will allow native pages to notify the compositor whether or not it needs the toolbar shadow drawn. BUG=614690 Committed: https://crrev.com/a86eb14b66aec353ca5f12980f53f5c7935371b5 Cr-Commit-Position: refs/heads/master@{#408165}

Patch Set 1 #

Patch Set 2 : handle non-google search providers #

Patch Set 3 : fix test code #

Messages

Total messages: 16 (7 generated)
mdjones
ptal
4 years, 5 months ago (2016-07-21 16:07:50 UTC) #2
mdjones
also +tedchoc
4 years, 5 months ago (2016-07-21 16:16:32 UTC) #4
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-21 16:33:19 UTC) #5
Ted C
lgtm
4 years, 5 months ago (2016-07-22 17:19:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161803002/20001
4 years, 4 months ago (2016-07-26 17:21:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/102158)
4 years, 4 months ago (2016-07-26 17:37:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161803002/40001
4 years, 4 months ago (2016-07-27 16:45:57 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-27 17:21:57 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:24:20 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a86eb14b66aec353ca5f12980f53f5c7935371b5
Cr-Commit-Position: refs/heads/master@{#408165}

Powered by Google App Engine
This is Rietveld 408576698