customtabs: Don't crash when the death notificaton is sent to a random thread.

customtabs: Don't crash when the death notificaton is sent to a random thread.

When a Custom Tabs client dies, the Android framework sends a
notification to an IBinder.DeathRecipient. This is relayed by
CustomTabsSessionToken to CustomTabsConnection#cleanUpSession(). If this
method is called from a different thread than the UI thread, then this
triggers a native crash.
Avoid that crash by making sure that mClientManger#cleanupSession() (and
then CustomTabsConnection#cancelPrerender()) is called from the UI thread.

Also add a non-regression test.

BUG=623128
Committed: https://crrev.com/1fb838fe1139f442dc24eddb08aa3b3bb408c5d8
Cr-Commit-Position: refs/heads/master@{#407101}

[Benoit L, 2016-07-18 15:27:22]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org

[Benoit L, 2016-07-21 13:04:49]

On 2016/07/18 15:27:23, Benoit L wrote:

Turns out that this was an issue in the past:
https://codereview.chromium.org/1304963004

[Yusuf, 2016-07-21 17:28:22]

Good catch and thanks once again :)

lgtm

[Benoit L, 2016-07-21 19:24:55]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:25:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:40:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:40:27]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Benoit L, 2016-07-22 08:18:16]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2016-07-22 08:18:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 08:47:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-22 08:48:56]

Description was changed from

==========
customtabs: Don't crash when the death notificaton is sent to a random thread.

When a Custom Tabs client dies, the Android framework sends a
notification to an IBinder.DeathRecipient. This is relayed by
CustomTabsSessionToken to CustomTabsConnection#cleanUpSession(). If this
method is called from a different thread than the UI thread, then this
triggers a native crash.
Avoid that crash by making sure that mClientManger#cleanupSession() (and
then CustomTabsConnection#cancelPrerender()) is called from the UI thread.

Also add a non-regression test.

BUG=623128
==========

to

==========
customtabs: Don't crash when the death notificaton is sent to a random thread.

When a Custom Tabs client dies, the Android framework sends a
notification to an IBinder.DeathRecipient. This is relayed by
CustomTabsSessionToken to CustomTabsConnection#cleanUpSession(). If this
method is called from a different thread than the UI thread, then this
triggers a native crash.
Avoid that crash by making sure that mClientManger#cleanupSession() (and
then CustomTabsConnection#cancelPrerender()) is called from the UI thread.

Also add a non-regression test.

BUG=623128

Committed: https://crrev.com/1fb838fe1139f442dc24eddb08aa3b3bb408c5d8
Cr-Commit-Position: refs/heads/master@{#407101}
==========

[commit-bot: I haz the power, 2016-07-22 08:48:57]

Patchset 1 (id:??) landed as
https://crrev.com/1fb838fe1139f442dc24eddb08aa3b3bb408c5d8
Cr-Commit-Position: refs/heads/master@{#407101}