Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1304963004: customtabs: Run the session cleanup code on the UI thread. (Closed)

Created:
5 years, 4 months ago by Benoit L
Modified:
5 years, 4 months ago
Reviewers:
pasko, Yusuf
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Run the session cleanup code on the UI thread. This fixes two issues, a test issue and a real one: - CustomTabsConnectionTest#tearDown() doesn't run on the UI thread. It calls CustomTabsConnection#cleanupAll() which calls a method that has to run on the UI thread. Run CustomTabsConnectionTest#tearDown() on the UI thread to fix this. - IBinder.DeathRecipient#binderDied() is not necessarily called on the UI thread, and has to unregister the death recipient. BUG=523057 Committed: https://crrev.com/e26acf52b32b3e49ceec2b58f0e86cc932b9715b Cr-Commit-Position: refs/heads/master@{#344797}

Patch Set 1 #

Patch Set 2 : Re-enable the disabled test. #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 4 chunks +27 lines, -10 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java View 1 2 4 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benoit L
5 years, 4 months ago (2015-08-21 09:50:22 UTC) #2
pasko
good catch! lgtm
5 years, 4 months ago (2015-08-21 12:06:55 UTC) #3
Yusuf
lgtm. Thanks Benoit!
5 years, 4 months ago (2015-08-21 16:52:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304963004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304963004/40001
5 years, 4 months ago (2015-08-21 16:55:49 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-21 17:09:31 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 17:10:14 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e26acf52b32b3e49ceec2b58f0e86cc932b9715b
Cr-Commit-Position: refs/heads/master@{#344797}

Powered by Google App Engine
This is Rietveld 408576698