components/subresource_filter/content/renderer/ruleset_dealer.h - Issue 2158833002: Factor DocumentSubresourceFilter out of SubresourceFilterAgent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/ruleset_dealer.h

Issue 2158833002: Factor DocumentSubresourceFilter out of SubresourceFilterAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from pkalinnikov@ Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc ('k') | components/subresource_filter/content/renderer/ruleset_dealer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/ruleset_dealer.h

diff --git a/components/subresource_filter/content/renderer/ruleset_dealer.h b/components/subresource_filter/content/renderer/ruleset_dealer.h

index 2054c61a8c7760b38c755990167ee46f1a188351..556342b6d22955936864451316221aeb2509d543 100644

--- a/components/subresource_filter/content/renderer/ruleset_dealer.h

+++ b/components/subresource_filter/content/renderer/ruleset_dealer.h

@@ -28,14 +28,17 @@ class RulesetDealer : public content::RenderThreadObserver {

RulesetDealer();

~RulesetDealer() override;

- const scoped_refptr<MemoryMappedRuleset>& ruleset() { return ruleset_; }

+ // Sets the |ruleset_file| to memory map and distribute from now on.

+ void SetRulesetFile(base::File ruleset_file);

+ const scoped_refptr<const MemoryMappedRuleset>& ruleset() { return ruleset_; }

private:

// content::RenderThreadObserver:

bool OnControlMessageReceived(const IPC::Message& message) override;

void OnSetRulesetForProcess(const IPC::PlatformFileForTransit& file);

- scoped_refptr<MemoryMappedRuleset> ruleset_;

+ scoped_refptr<const MemoryMappedRuleset> ruleset_;

DISALLOW_COPY_AND_ASSIGN(RulesetDealer);

};