Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: components/subresource_filter/content/renderer/ruleset_dealer.cc

Issue 2158833002: Factor DocumentSubresourceFilter out of SubresourceFilterAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from pkalinnikov@ Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/renderer/ruleset_dealer.cc
diff --git a/components/subresource_filter/content/renderer/ruleset_dealer.cc b/components/subresource_filter/content/renderer/ruleset_dealer.cc
index df0bfc58dad20cc5bb313591a426e9141c664fc9..cab81330dab454f916c0da2e406401ad1d062e3d 100644
--- a/components/subresource_filter/content/renderer/ruleset_dealer.cc
+++ b/components/subresource_filter/content/renderer/ruleset_dealer.cc
@@ -17,6 +17,11 @@ namespace subresource_filter {
RulesetDealer::RulesetDealer() = default;
RulesetDealer::~RulesetDealer() = default;
+void RulesetDealer::SetRulesetFile(base::File ruleset_file) {
+ DCHECK(ruleset_file.IsValid());
+ ruleset_ = new MemoryMappedRuleset(std::move(ruleset_file));
+}
+
bool RulesetDealer::OnControlMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(RulesetDealer, message)
@@ -29,9 +34,7 @@ bool RulesetDealer::OnControlMessageReceived(const IPC::Message& message) {
void RulesetDealer::OnSetRulesetForProcess(
const IPC::PlatformFileForTransit& platform_file) {
- base::File file = IPC::PlatformFileForTransitToFile(platform_file);
- DCHECK(file.IsValid());
- ruleset_ = new MemoryMappedRuleset(std::move(file));
+ SetRulesetFile(IPC::PlatformFileForTransitToFile(platform_file));
}
} // namespace subresource_filter

Powered by Google App Engine
This is Rietveld 408576698