Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2158793003: [builtins] move array builtins into its own file. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@declares
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] move array builtins into its own file. R=jgruber@chromium.org BUG=v8:5197 Committed: https://crrev.com/aa601a6a671404cc95e689f4a61b8c522a96cfd7 Cr-Commit-Position: refs/heads/master@{#37838}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1559 lines, -1522 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins.cc View 1 6 chunks +145 lines, -1522 lines 0 comments Download
A src/builtins/builtins-array.cc View 1 chunk +1275 lines, -0 lines 0 comments Download
A src/builtins/builtins-utils.h View 1 chunk +135 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
4 years, 5 months ago (2016-07-18 09:33:21 UTC) #1
jgruber
lgtm
4 years, 5 months ago (2016-07-18 10:09:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158793003/1
4 years, 5 months ago (2016-07-18 11:35:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/5194)
4 years, 5 months ago (2016-07-18 11:37:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158793003/20001
4 years, 5 months ago (2016-07-18 12:45:47 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 13:12:15 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 13:18:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa601a6a671404cc95e689f4a61b8c522a96cfd7
Cr-Commit-Position: refs/heads/master@{#37838}

Powered by Google App Engine
This is Rietveld 408576698