Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2158783002: Revert of Credit card editor for PaymentRequest UI. (Closed)

Created:
4 years, 5 months ago by Benoit L
Modified:
4 years, 5 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Credit card editor for PaymentRequest UI. (patchset #5 id:490001 of https://codereview.chromium.org/2116583002/ ) Reason for revert: Broke Android Tests (dbg). BUG=629011, 624924 Original issue's description: > Credit card editor for PaymentRequest UI. > > When user taps on an incomplete autofill credit card or [+ ADD CARD] > button, the card editor launches. > > For server cards, the editor shows uneditable card information and lets > the user set the billing address. > > For local cards, the editor shows the following fields. > > 1) A list of icons for supported card types. > > 2) The card number input with Luhn validation and formatting. Required > field. > > 3) The name on card input. Required field. > > 4) The month and year dropdowns. January of this year by default for new > cards. > > 5) The billing address dropdown with only complete addresses on disk and > an option to add a new address. Required field. > > 6) A checkbox for saving the new card on disk. Checked by default, > so it behaves similar to autofill settings. > > BUG=624924 > > Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea > Cr-Commit-Position: refs/heads/master@{#405876} TBR=mathp@chromium.org,dfalcantara@chromium.org,estade@chromium.org,rouslan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f Cr-Commit-Position: refs/heads/master@{#405971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -1978 lines) Patch
D chrome/android/java/res/drawable-hdpi/pr_dinersclub.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/pr_jcb.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/pr_unionpay.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/pr_dinersclub.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/pr_jcb.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/pr_unionpay.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/pr_dinersclub.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/pr_jcb.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/pr_unionpay.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/pr_dinersclub.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/pr_jcb.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/pr_unionpay.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/pr_dinersclub.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/pr_jcb.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/pr_unionpay.png View Binary file 0 comments Download
M chrome/android/java/res/layout/payment_request_editor_dropdown.xml View 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/android/java/res/layout/payment_request_editor_icons.xml View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/android/java/res/layout/payment_request_editor_label.xml View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/res/values/ids.xml View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 10 chunks +44 lines, -53 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java View 5 chunks +30 lines, -33 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java View 6 chunks +28 lines, -70 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java View 1 chunk +0 lines, -543 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 17 chunks +18 lines, -63 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java View 5 chunks +5 lines, -33 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java View 8 chunks +34 lines, -204 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorLabelField.java View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java View 6 chunks +19 lines, -42 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 14 chunks +74 lines, -172 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java View 2 chunks +11 lines, -29 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 6 chunks +3 lines, -17 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/payments/ui/Validatable.java View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java View 2 chunks +92 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java View 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/CreditCardNumberFormattingTextWatcher.java View 1 chunk +0 lines, -99 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 2 chunks +42 lines, -33 lines 0 comments Download
M chrome/android/java_sources.gni View 4 chunks +0 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java View 3 chunks +16 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java View 7 chunks +0 lines, -98 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 8 chunks +3 lines, -90 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java View 1 chunk +10 lines, -15 lines 0 comments Download
M chrome/browser/android/resource_id.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.h View 3 chunks +2 lines, -40 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 7 chunks +6 lines, -72 lines 0 comments Download
M chrome/test/data/android/payments/no_shipping.js View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/payments/full_card_request.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/autofill/core/browser/payments/full_card_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill_strings.grdp View 1 chunk +7 lines, -7 lines 0 comments Download
M components/resources/autofill_scaled_resources.grdp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Benoit L
Created Revert of Credit card editor for PaymentRequest UI.
4 years, 5 months ago (2016-07-18 09:27:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158783002/1
4 years, 5 months ago (2016-07-18 09:28:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 10:14:51 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 10:14:53 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 10:16:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f
Cr-Commit-Position: refs/heads/master@{#405971}

Powered by Google App Engine
This is Rietveld 408576698