Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2158763002: Revert of [Payments] Add ability to bold parts of addresses (Closed)

Created:
4 years, 5 months ago by markusheintz_
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@payments_continuing
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Payments] Add ability to bold parts of addresses (patchset #4 id:60001 of https://codereview.chromium.org/2135573004/ ) Reason for revert: Android Test builder is failing since https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35304 see https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35304/steps/chrome_public_test_apk/logs/stdio This may be one of two CLs that could have caused this (the other is https://codereview.chromium.org/2116583002). Since the two CLs have some files in common I'll start reverting this one first. Original issue's description: > [Payments] Add ability to bold parts of addresses > > * Add the ability to bold parts of a label. > > * Add the ability to show a tertiary label in the PaymentOption, which > will later be used for phone number display. > > * The phone number is passed in to the PaymentOption using the new constructor > via the AutofillAddress class. > > See crbug.com/626833 for screenshots. > > BUG=603635, 626833 > > Committed: https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f > Cr-Commit-Position: refs/heads/master@{#405900} TBR=rouslan@chromium.org,mathp@chromium.org,dfalcantara@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603635, 626833 Committed: https://crrev.com/bdf235c56a359c2181ad5e664a2cbb442892e5de Cr-Commit-Position: refs/heads/master@{#405968}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
markusheintz_
Created Revert of [Payments] Add ability to bold parts of addresses
4 years, 5 months ago (2016-07-18 08:25:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158763002/1
4 years, 5 months ago (2016-07-18 08:26:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 09:02:21 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 09:03:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdf235c56a359c2181ad5e664a2cbb442892e5de
Cr-Commit-Position: refs/heads/master@{#405968}

Powered by Google App Engine
This is Rietveld 408576698