[Typed-OM] Add StringOrCSSVariableReferenceValue type

[Typed-OM] Add StringOrCSSVariableReferenceValue type

StringOrCSSVariableReferenceValue is used in CSSTokenStreamValue (spec: https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects).

In this CL the Iterable in CSSTokenStreamValue is changed to this compound type instead of only string (https://codereview.chromium.org/2122193003/).

BUG=545318
Committed: https://crrev.com/fa4c3e436c07d408a3bb6b31cb4e0fc9761c61f2
Cr-Commit-Position: refs/heads/master@{#406794}

[anthonyhkf, 2016-07-18 06:48:46]

The CQ bit was checked by anthonyhkf@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 06:49:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 06:56:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 06:56:12]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ms770404, 2016-07-18 06:57:32]

ms770404@gmail.com changed reviewers:
+ ms770404@gmail.com

[ms770404, 2016-07-18 06:57:32]

lgtm

[ms770404, 2016-07-18 07:37:44]

On 2016/07/18 06:57:32, ms770404 wrote:
> lgtm

[anthonyhkf, 2016-07-20 01:37:51]

The CQ bit was checked by anthonyhkf@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 01:38:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[anthonyhkf, 2016-07-20 03:03:55]

anthonyhkf@google.com changed reviewers:
+ meade@chromium.org
- ms770404@gmail.com

[meade_UTC10, 2016-07-20 03:20:29]

lgtm

https://codereview.chromium.org/2158733003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.cpp (right):

https://codereview.chromium.org/2158733003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.cpp:28: value =
result;
Instead of the above three lines, you could just write

value.setString(m_tokenStreamValue->fragmentAtIndex(m_index));

[meade_UTC10, 2016-07-20 03:23:41]

On 2016/07/20 03:20:29, Eddy wrote:
> lgtm
> 
>
https://codereview.chromium.org/2158733003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.cpp (right):
> 
>
https://codereview.chromium.org/2158733003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.cpp:28: value =
> result;
> Instead of the above three lines, you could just write
> 
> value.setString(m_tokenStreamValue->fragmentAtIndex(m_index));

Please also add more description to your CL - why are you adding this compound
type, and what are the other changes in the CL?

[meade_UTC10, 2016-07-20 03:24:25]

meade@chromium.org changed reviewers:
+ bashi@chromium.org

[meade_UTC10, 2016-07-20 03:24:25]

Hi Kenichi,

Could you PTAL at the changes for bindings/core/v8/generated.*?

Thank you!
Eddy

[anthonyhkf, 2016-07-20 03:33:37]

Description was changed from

==========
[Typed-OM] Add StringOrCSSVariableReferenceValue type

BUG=545318
==========

to

==========
[Typed-OM] Add StringOrCSSVariableReferenceValue type

StringOrCSSVariableReferenceValue is used in CSSTokenStreamValue (spec:
https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects).

In this CL the Iterable in CSSTokenStreamValue is changed to this compound type
instead of only string (https://codereview.chromium.org/2122193003/).

BUG=545318
==========

[meade_UTC10, 2016-07-20 03:45:08]

meade@chromium.org changed reviewers:
+ dstockwell@chromium.org

[meade_UTC10, 2016-07-20 03:45:08]

Doug: Could you PTAL for blink owners? Thanks!

[commit-bot: I haz the power, 2016-07-20 04:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 04:06:02]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[haraken, 2016-07-20 07:24:57]

bindings/ LGTM

[anthonyhkf, 2016-07-20 10:04:35]

The CQ bit was checked by anthonyhkf@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 10:04:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 12:22:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 12:22:19]

Dry run: This issue passed the CQ dry run.

[bashi, 2016-07-21 01:06:48]

lgtm (sorry missed this)

[dstockwell, 2016-07-21 01:52:09]

dstockwell@chromium.org changed reviewers:
+ haraken@chromium.org, ms770404@gmail.com

[dstockwell, 2016-07-21 01:52:10]

lgtm

[anthonyhkf, 2016-07-21 06:37:55]

Thanks :)

[anthonyhkf, 2016-07-21 06:38:10]

The CQ bit was checked by anthonyhkf@google.com

[anthonyhkf, 2016-07-21 06:38:10]

The patchset sent to the CQ was uploaded after l-g-t-m from ms770404@gmail.com,
meade@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2158733003/#ps40001
(title: "Simplify variable")

[commit-bot: I haz the power, 2016-07-21 06:38:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 07:09:40]

Description was changed from

==========
[Typed-OM] Add StringOrCSSVariableReferenceValue type

StringOrCSSVariableReferenceValue is used in CSSTokenStreamValue (spec:
https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects).

In this CL the Iterable in CSSTokenStreamValue is changed to this compound type
instead of only string (https://codereview.chromium.org/2122193003/).

BUG=545318
==========

to

==========
[Typed-OM] Add StringOrCSSVariableReferenceValue type

StringOrCSSVariableReferenceValue is used in CSSTokenStreamValue (spec:
https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects).

In this CL the Iterable in CSSTokenStreamValue is changed to this compound type
instead of only string (https://codereview.chromium.org/2122193003/).

BUG=545318
==========

[commit-bot: I haz the power, 2016-07-21 07:09:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-21 07:13:02]

Description was changed from

==========
[Typed-OM] Add StringOrCSSVariableReferenceValue type

StringOrCSSVariableReferenceValue is used in CSSTokenStreamValue (spec:
https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects).

In this CL the Iterable in CSSTokenStreamValue is changed to this compound type
instead of only string (https://codereview.chromium.org/2122193003/).

BUG=545318
==========

to

==========
[Typed-OM] Add StringOrCSSVariableReferenceValue type

StringOrCSSVariableReferenceValue is used in CSSTokenStreamValue (spec:
https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects).

In this CL the Iterable in CSSTokenStreamValue is changed to this compound type
instead of only string (https://codereview.chromium.org/2122193003/).

BUG=545318

Committed: https://crrev.com/fa4c3e436c07d408a3bb6b31cb4e0fc9761c61f2
Cr-Commit-Position: refs/heads/master@{#406794}
==========

[commit-bot: I haz the power, 2016-07-21 07:13:03]

Patchset 3 (id:??) landed as
https://crrev.com/fa4c3e436c07d408a3bb6b31cb4e0fc9761c61f2
Cr-Commit-Position: refs/heads/master@{#406794}