[Typed-OM] Add compound type of CSSVariableReferenceValue and String with some tests

[Typed-OM] Add compound type of CSSVariableReferenceValue and String with some tests

Spec: https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects

BUG=545318
Committed: https://crrev.com/582dce63a892bff908796380281c2106fb521b3b
Cr-Commit-Position: refs/heads/master@{#409975}

[anthonyhkf, 2016-07-12 23:46:43]

anthonyhkf@google.com changed reviewers:
+ meade@chromium.org

[anthonyhkf, 2016-07-13 01:33:14]

Description was changed from

==========
Add compound type of CSSVariableReferenceValue and String with some tests

BUG=545318
==========

to

==========
[Typed-OM] Add compound type of CSSVariableReferenceValue and String with some
tests

BUG=545318
==========

[anthonyhkf, 2016-07-13 01:53:36]

Description was changed from

==========
[Typed-OM] Add compound type of CSSVariableReferenceValue and String with some
tests

BUG=545318
==========

to

==========
[Typed-OM] Add compound type of CSSVariableReferenceValue and String with some
tests

Spec: https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects

BUG=545318
==========

[meade_UTC10, 2016-07-14 00:59:30]

You also need to:

- sync (looks like you landed the initial patch for CSSVariableReferenceValue in
http://crrev.com/2126713002)
- Make sure all the animation test changes are reverted in this CL (might be
solved by syncing)
- Move bindings/core/v8/generated.gni and bindings/core/v8/generated.gypi to a
separate CL

https://codereview.chromium.org/2140073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.cpp (right):

https://codereview.chromium.org/2140073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.cpp:66:
tokens.append(m_listOfReferences[i].getAsString());
You need to check

m_listOfReferences[i].isString() before calling getAsString(). It could be a
VariableReferenceValue, in which case you'll want to do

tokens.append(m_listOfReferences[i].getAsCSSVariableReferenceValue().variable());

[anthonyhkf, 2016-07-15 11:58:43]

https://codereview.chromium.org/2140073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.cpp (right):

https://codereview.chromium.org/2140073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.cpp:66:
tokens.append(m_listOfReferences[i].getAsString());
On 2016/07/14 00:59:30, Eddy wrote:
> You need to check
> 
> m_listOfReferences[i].isString() before calling getAsString(). It could be a
> VariableReferenceValue, in which case you'll want to do
> 
>
tokens.append(m_listOfReferences[i].getAsCSSVariableReferenceValue().variable());

Done.

[meade_UTC10, 2016-07-18 06:21:38]

meade@chromium.org changed reviewers:
+ shans@chromium.org

[meade_UTC10, 2016-07-18 06:21:39]

This lgtm (with comments), but you still need to make the separate CL with that
gypi and gni file as per my first comment. This CL will be dependent on that.

https://codereview.chromium.org/2140073002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.cpp (right):

https://codereview.chromium.org/2140073002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.cpp:70:
tokens.append(m_listOfReferences[i].getAsCSSVariableReferenceValue()->variable());
Theoretically it could still be null, how about this?

if (m_listOfReferences[i].isString())
...
else if (m_listOfReferences[i].isCSSVariableReferenceValue())
...
else
  NOTREACHED();

[anthonyhkf, 2016-07-19 01:23:32]

The CQ bit was checked by anthonyhkf@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 01:24:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 03:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 03:04:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[anthonyhkf, 2016-07-20 02:57:19]

The CQ bit was checked by anthonyhkf@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 02:57:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 04:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 04:03:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[anthonyhkf, 2016-07-20 10:23:52]

The CQ bit was checked by anthonyhkf@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 10:24:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 11:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 11:59:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[anthonyhkf, 2016-07-21 00:04:37]

The CQ bit was checked by anthonyhkf@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 00:05:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 01:15:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 01:15:53]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2016-07-25 07:01:54]

Shane ptal?

[shans, 2016-07-27 03:25:49]

On 2016/07/25 at 07:01:54, meade wrote:
> Shane ptal?

lgtm

[meade_UTC10, 2016-07-27 06:34:17]

meade@chromium.org changed reviewers:
+ dstockwell@chromium.org

[meade_UTC10, 2016-07-27 06:34:18]

+Doug for OWNERS review! PTAL :)

[meade_UTC10, 2016-07-29 07:15:27]

Psst, LayoutTests are failing.

Also ping doug?

[meade_UTC10, 2016-07-29 07:16:14]

Oops, was looking at the wrong patch set. But Doug still needs to have a look :)

[dstockwell, 2016-08-02 01:49:34]

lgtm

[anthonyhkf, 2016-08-05 00:51:25]

The CQ bit was checked by anthonyhkf@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 00:51:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 02:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 02:29:12]

Dry run: This issue passed the CQ dry run.

[anthonyhkf, 2016-08-05 02:58:39]

The CQ bit was checked by anthonyhkf@google.com

[anthonyhkf, 2016-08-05 02:58:40]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
dstockwell@chromium.org, shans@chromium.org
Link to the patchset: https://codereview.chromium.org/2140073002/#ps200001
(title: "Rebase-update")

[commit-bot: I haz the power, 2016-08-05 02:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 03:02:29]

Description was changed from

==========
[Typed-OM] Add compound type of CSSVariableReferenceValue and String with some
tests

Spec: https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects

BUG=545318
==========

to

==========
[Typed-OM] Add compound type of CSSVariableReferenceValue and String with some
tests

Spec: https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects

BUG=545318
==========

[commit-bot: I haz the power, 2016-08-05 03:02:31]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-08-05 03:04:58]

Description was changed from

==========
[Typed-OM] Add compound type of CSSVariableReferenceValue and String with some
tests

Spec: https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects

BUG=545318
==========

to

==========
[Typed-OM] Add compound type of CSSVariableReferenceValue and String with some
tests

Spec: https://drafts.css-houdini.org/css-typed-om/#tokenstreamvalue-objects

BUG=545318

Committed: https://crrev.com/582dce63a892bff908796380281c2106fb521b3b
Cr-Commit-Position: refs/heads/master@{#409975}
==========

[commit-bot: I haz the power, 2016-08-05 03:04:59]

Patchset 11 (id:??) landed as
https://crrev.com/582dce63a892bff908796380281c2106fb521b3b
Cr-Commit-Position: refs/heads/master@{#409975}