Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2158713002: MD Settings: actually compile settings_ui.js (Closed)

Created:
4 years, 5 months ago by michaelpg
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: actually compile settings_ui.js BUG=NONE R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b263cdf7642ad64a41d6c576e6e81ec0b2ace9f0 Cr-Commit-Position: refs/heads/master@{#406212}

Patch Set 1 #

Patch Set 2 : rebase on 2155063003 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M chrome/browser/resources/settings/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 1 3 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2155063003 Patch 20001

Messages

Total messages: 14 (6 generated)
michaelpg
4 years, 5 months ago (2016-07-17 23:13:14 UTC) #2
Dan Beam
lgtm
4 years, 5 months ago (2016-07-18 04:54:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158713002/20001
4 years, 5 months ago (2016-07-18 20:33:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/105906)
4 years, 5 months ago (2016-07-18 23:12:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158713002/20001
4 years, 5 months ago (2016-07-19 03:47:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 04:16:24 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 04:16:28 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 04:19:22 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b263cdf7642ad64a41d6c576e6e81ec0b2ace9f0
Cr-Commit-Position: refs/heads/master@{#406212}

Powered by Google App Engine
This is Rietveld 408576698